Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Poll the main node API for attestation status - relaxed (BFT-496) #2583

Merged
merged 7 commits into from
Aug 6, 2024
Merged

feat: Poll the main node API for attestation status - relaxed (BFT-496) #2583

merged 7 commits into from
Aug 6, 2024

Conversation

aakoshh
Copy link
Contributor

@aakoshh aakoshh commented Aug 2, 2024 •
edited
Loading

What ❔

Reverts #2574 to re-establish the attestation status API integration, but also bumps the era-consensus version to 0.1.0-rc.6 which has changes to make it backwards compatible:

  • the Executor is started without waiting for the initial attestation batch number to become available, so as not to stop the node completely from participating in gossip without the main node API (this behaviour is internal to the AttesterStatusRunner)
  • invalid batch vote signatures are not rejected, just ignored, so the node doesn't break connection with a peer who signed a different payload while the feature is in flux

TODO:

  • Update once 0.1.0-rc.6 is published to crates.io

Why ❔

The first reason is to not be so eager to drop a gossip peer for incompatibilities between newer and existing versions of the software while we're actively working on the features involved.

The second is that the rollout strategy to mainnet seems to be to roll out external nodes first, main nodes second. It is expected that the external node should work with an older version of the main node, or at least not fail to start; it is okay if a new feature doesn't work.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@aakoshh aakoshh marked this pull request as ready for review August 2, 2024 14:41
@pompon0
Copy link
Contributor

pompon0 commented Aug 5, 2024

@aakoshh please bump to 0.1.0-rc.7

pompon0
pompon0 previously approved these changes Aug 5, 2024
View reviewed changes
@pompon0 pompon0 added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit b45aa91 Aug 6, 2024
53 checks passed
@pompon0 pompon0 deleted the bft-496-relax branch August 6, 2024 08:59
This was referenced Aug 5, 2024
Merged
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 7, 2024
@zksync-era-bot @RomanBrodetski
chore(main): release core 24.15.0 (#2577)
2cb7918 
🤖 I have created a release *beep* *boop*
---


##
[24.15.0](core-v24.14.0...core-v24.15.0)
(2024-08-07)


### Features

* optimize LWG and NWG
([#2512](#2512))
([0d00650](0d00650))
* Poll the main node API for attestation status - relaxed (BFT-496)
([#2583](#2583))
([b45aa91](b45aa91))
* **zk_toolbox:** allow to run `zk_inception chain create`
non-interactively
([#2579](#2579))
([555fcf7](555fcf7))


### Bug Fixes

* **core:** Handle GCS Response retriable errors
([#2588](#2588))
([4b74092](4b74092))
* **node:** respect namespaces configuration
([#2578](#2578))
([e2d9060](e2d9060))
* **vm-runner:** Fix data race in storage loader
([1810b78](1810b78))


### Reverts

* "feat: Poll the main node for the next batch to sign (BFT-496)"
([#2574](#2574))
([72d3be8](72d3be8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
Co-authored-by: Roman Brodetski <rb@matterlabs.dev>
github-merge-queue bot pushed a commit that referenced this pull request Aug 7, 2024
@zksync-era-bot @EmilLuta
chore(main): release prover 16.3.0 (#2596)
5a2bf52 
🤖 I have created a release *beep* *boop*
---


##
[16.3.0](prover-v16.2.0...prover-v16.3.0)
(2024-08-07)


### Features

* Poll the main node API for attestation status - relaxed (BFT-496)
([#2583](#2583))
([b45aa91](b45aa91))


### Bug Fixes

* **prover:** Fix NWG
([#2590](#2590))
([9b58ae9](9b58ae9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: EmilLuta <EmilLuta@users.noreply.github.com>
@zksync-era-bot zksync-era-bot mentioned this pull request Aug 7, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 16, 2024
@zksync-era-bot
chore(main): release prover 16.4.0 (#2615)
51259b6 
🤖 I have created a release *beep* *boop*
---


##
[16.4.0](prover-v16.3.0...prover-v16.4.0)
(2024-08-16)


### Features

* Bump harness & gpu deps
([#2634](#2634))
([2a7d566](2a7d566))
* Poll the main node API for attestation status - relaxed (BFT-496)
([#2583](#2583))
([b45aa91](b45aa91))
* **vlog:** Report observability config, flush, and shutdown
([#2622](#2622))
([e23e661](e23e661))
* **vm:** Extract VM interface to separate crate
([#2638](#2638))
([cb9ac4e](cb9ac4e))
* **vm:** Fast VM integration
([#1949](#1949))
([b752a54](b752a54))


### Bug Fixes

* Bump prover dependencies & rust toolchain
([#2600](#2600))
([849c6a5](849c6a5))
* **prover:** Fix NWG
([#2590](#2590))
([9b58ae9](9b58ae9))
* **prover:** Updated README.md
([#2604](#2604))
([be9f357](be9f357))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
github-merge-queue bot pushed a commit that referenced this pull request Aug 20, 2024
@zksync-era-bot
chore(main): release zk_toolbox 0.1.2 (#2584)
26ecc34 
🤖 I have created a release *beep* *boop*
---


##
[0.1.2](zk_toolbox-v0.1.1...zk_toolbox-v0.1.2)
(2024-08-20)


### Features

* Poll the main node API for attestation status - relaxed (BFT-496)
([#2583](#2583))
([b45aa91](b45aa91))
* update base token rate on L1
([#2589](#2589))
([f84aaaf](f84aaaf))
* **zk_toolbox:** Add installation script
([#2569](#2569))
([009cd97](009cd97))
* **zk_toolbox:** Add lint command
([#2626](#2626))
([3d02946](3d02946))
* **zk_toolbox:** Add observability interactive option
([#2592](#2592))
([3aeaaed](3aeaaed))
* **zk_toolbox:** Add zk_supervisor run unit tests command
([#2610](#2610))
([fa866cd](fa866cd))
* **zk_toolbox:** Add zk_supervisor test l1 contracts command
([#2613](#2613))
([931e452](931e452))
* **zk_toolbox:** Add zk_supervisor test prover command
([#2614](#2614))
([0fe173b](0fe173b))
* **zk_toolbox:** allow to run `zk_inception chain create`
non-interactively
([#2579](#2579))
([555fcf7](555fcf7))
* **zk_toolbox:** Minting base token
([#2571](#2571))
([ae2dd3b](ae2dd3b))
* **zk_toolbox:** Run formatters and linterrs
([#2675](#2675))
([caedd1c](caedd1c))


### Bug Fixes

* Bump prover dependencies & rust toolchain
([#2600](#2600))
([849c6a5](849c6a5))
* **zk_toolbox:** Do not panic during mint
([#2658](#2658))
([1a8ee90](1a8ee90))
* **zk_toolbox:** Get l1-network config param from flag
([#2603](#2603))
([553d307](553d307))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pompon0 pompon0 pompon0 approved these changes

@brunoffranca brunoffranca Awaiting requested review from brunoffranca

@RomanBrodetski RomanBrodetski Awaiting requested review from RomanBrodetski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aakoshh @pompon0 @brunoffranca