fix(proof_data_handler): TEE blob fetching error handling #2674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbeza
force-pushed
the
tee/fix/tee-prover-error-handling
branch
2 times, most recently
from
f84702b to
56b0c80
Compare
We ran into a problem in the staging environment where TEE blob fetching failed because of a 30-day retention policy on blobs in Google Cloud Storage. The TEE prover was failing for all old batches (`l1_batch_number < 58300`). This commit fixes the issue by adding better error handling when the blob for a given batch number isn't available.
pbeza
force-pushed
the
tee/fix/tee-prover-error-handling
branch
from
56b0c80 to
61804e3
Compare
|
Tested. It seems to be working. ✅ Not sure who to ask for a review while @popzxc is on vacation. I used to ask him for all my |
pbeza
commented
Aug 16, 2024
EmilLuta
reviewed
Aug 19, 2024
slowli
reviewed
Aug 20, 2024
Also, cherry-pick some of the ideas introduced in #2486
pbeza
force-pushed
the
tee/fix/tee-prover-error-handling
branch
from
2476f18 to
27360a9
Compare
slowli
reviewed
Aug 22, 2024
|
@slowli Could you please approve if it looks good? Thanks! |
slowli
approved these changes
Aug 23, 2024
thomasknauth
approved these changes
Aug 23, 2024
|
@thomasknauth / @haraldh / @slowli, could you merge this? I don't have the permissions. I think 2 approvals ✅✅ should be good enough. Thanks! |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
🤖 I have created a release *beep* *boop* --- ## [24.22.0](core-v24.21.0...core-v24.22.0) (2024-08-27) ### Features * add flag to enable/disable DA inclusion verification ([#2647](#2647)) ([b425561](b425561)) * **Base token:** add cbt metrics ([#2720](#2720)) ([58438eb](58438eb)) * Change default_protective_reads_persistence_enabled to false ([#2716](#2716)) ([8d0eee7](8d0eee7)) * **vm:** Extract oneshot VM executor interface ([#2671](#2671)) ([951d5f2](951d5f2)) * **zk_toolbox:** Add holesky testnet as layer1 network ([#2632](#2632)) ([d9266e5](d9266e5)) ### Bug Fixes * **api:** `tx.gas_price` field ([#2734](#2734)) ([aea3726](aea3726)) * **base_token_adjuster:** bug with a wrong metrics namespace ([#2744](#2744)) ([64b2ff8](64b2ff8)) * **eth-sender:** missing Gateway migration changes ([#2732](#2732)) ([a4170e9](a4170e9)) * **proof_data_handler:** TEE blob fetching error handling ([#2674](#2674)) ([c162510](c162510)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into a problem in the staging environment where TEE blob fetching failed because of a 30-day retention policy on blobs in Google Cloud Storage. The TEE prover was failing for all old batches (
l1_batch_number < 58300). This commit fixes the issue by adding better error handling when the blob for a given batch number isn't available.What ❔
Graceful error handling for the TEE proof data handler when there is no blob in Google Cloud Storage for the specified batch number.
Why ❔
We need more robust error handling.
Checklist
zk fmtandzk lint.