Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prover): fail when fri prover job is not found #2711

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

itegulov
Copy link
Contributor

What ❔

Compressor should fail when a corresponding fri prover job is not found. Unlikely to occur in real world but helps when manually populating DB for debugging.

Why ❔

This behaviour makes more sense

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@itegulov itegulov requested a review from EmilLuta August 22, 2024 10:55
@itegulov itegulov enabled auto-merge August 22, 2024 10:56
Co-authored-by: EmilLuta <EmilLuta@users.noreply.github.com>
@itegulov itegulov added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit 8776875 Aug 22, 2024
28 checks passed
@itegulov itegulov deleted the daniyar/prover/compressor-next-job branch August 22, 2024 11:37
github-merge-queue bot pushed a commit that referenced this pull request Aug 28, 2024
🤖 I have created a release *beep* *boop*
---


##
[16.5.0](prover-v16.4.0...prover-v16.5.0)
(2024-08-28)


### Features

* **prover_cli:** Add test for status, l1 and config commands.
([#2263](#2263))
([6a2e3b0](6a2e3b0))
* **prover_cli:** Stuck status
([#2441](#2441))
([232a817](232a817))
* **prover:** Add ProverJobMonitor
([#2666](#2666))
([e22cfb6](e22cfb6))
* **prover:** parallelized memory queues simulation in BWG
([#2652](#2652))
([b4ffcd2](b4ffcd2))
* Provide easy prover setup
([#2683](#2683))
([30edda4](30edda4))


### Bug Fixes

* **prover_cli:** Remove congif file check
([#2695](#2695))
([2f456f0](2f456f0))
* **prover_cli:** Update prover cli README
([#2700](#2700))
([5a9bbb3](5a9bbb3))
* **prover:** change bucket for RAM permutation witnesses
([#2672](#2672))
([8b4cbf4](8b4cbf4))
* **prover:** fail when fri prover job is not found
([#2711](#2711))
([8776875](8776875))
* **prover:** Revert use of spawn_blocking in LWG/NWG
([#2682](#2682))
([edfcc7d](edfcc7d))
* **prover:** speed up LWG and NWG
([#2661](#2661))
([6243399](6243399))
* **vm:** Fix used bytecodes divergence
([#2741](#2741))
([923e33e](923e33e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants