chore: replace assert!(matches!(...)) with assert_matches!(...)

[pbeza]

What ❔

Replace assert!(matches!(...)) with assert_matches!(...).

Why ❔

To make the code more idiomatic.

Checklist

• PR title corresponds to the body of PR (we generate changelog entries from PRs).
• Tests for the changes have been added / updated.
• Documentation comments have been added / updated.
• Code has been formatted via zk fmt and zk lint.

[pbeza]

I didn't know we disallow unstable features:

error: use of an unstable feature
 --> core/lib/types/src/lib.rs:7:12
  |
7 | #![feature(assert_matches)]
  |            ^^^^^^^^^^^^^^
  |
  = note: requested on the command line with `-D unstable-features`

so I give up this PR for now. Waiting for assert_matches! to become a standard Rust feature. It's amazing how long people can debate over what seems like trivial features. :P

[popzxc]

I didn't know we disallow unstable features

@pbeza We do. We only use nightly because we're forced to (crypto deps), but we want to eventually get back to stable. Any nightly feature makes it harder.

However, we have assert_matches in our dependency tree already, so you can simply add it to dev-dependencies.

[pbeza]

Fixed 🫡 @popzxc, PTAL

[pbeza]

@popzxc, this PR was removed from the merge queue due to failed status checks:

running unit tests with 'cargo nextest run --release '
error: duplicate key `workspace` in table `dev-dependencies`
  --> core/lib/multivm/Cargo.toml:45:1
   |
45 | assert_matches.workspace = true
   | ^
   |
error: failed to load manifest for workspace member `/usr/src/zksync/core/bin/block_reverter`
referenced by workspace at `/usr/src/zksync/Cargo.toml`

It doesn't make sense for me – there is no duplicate there. What am I missing here?

[popzxc]

@pbeza assert_matches was just added to the multivm deps by another PR that got merged before yours.
Merge main, resolve the issue, and push.