refactor(dal): strong typing for TEE proof status

[pbeza]

What ❔

Introduce strong typing for the TEE proof generation status in the Rust code only (not in the database). This is a followup for:

• feat(tee): introduce get_tee_proofs RPC method for TEE proofs #2474 (comment)
• feat(tee): introduce get_tee_proofs RPC method for TEE proofs #2474 (comment)

This PR also aligns the status types with those implemented in proof_generation_dal.rs (specifically the unpicked status introduced in #2258).

Why ❔

Strong typing makes it easier to reason about the code and helps protect against subtle bugs.

Checklist

• PR title corresponds to the body of PR (we generate changelog entries from PRs).
• Tests for the changes have been added / updated.
• Documentation comments have been added / updated.
• Code has been formatted via zk fmt and zk lint.

[pbeza]

I'm not sure why the CI is erroring out on code I haven't even touched. 🤷‍♂️

error: the borrowed expression implements the required traits
  --> crates/zk_supervisor/src/commands/database/reset.rs:29:22
   |
29 |         logger::info(&msg_database_loading(MSG_DATABASE_RESET_GERUND, &dal.path));
   |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `msg_database_loading(MSG_DATABASE_RESET_GERUND, &dal.path)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
   = note: `-D clippy::needless-borrows-for-generic-args` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::needless_borrows_for_generic_args)]`

error: the borrowed expression implements the required traits
 --> crates/zk_supervisor/src/commands/test/prover.rs:9:37
  |
9 |     let _dir_guard = shell.push_dir(&ecosystem.link_to_code.join("prover"));
  |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ecosystem.link_to_code.join("prover")`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

@aon @popzxc @Deniallugo any idea?

[Deniallugo]

I'm not sure why the CI is erroring out on code I haven't even touched. 🤷‍♂️

error: the borrowed expression implements the required traits
  --> crates/zk_supervisor/src/commands/database/reset.rs:29:22
   |
29 |         logger::info(&msg_database_loading(MSG_DATABASE_RESET_GERUND, &dal.path));
   |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `msg_database_loading(MSG_DATABASE_RESET_GERUND, &dal.path)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
   = note: `-D clippy::needless-borrows-for-generic-args` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::needless_borrows_for_generic_args)]`

error: the borrowed expression implements the required traits
 --> crates/zk_supervisor/src/commands/test/prover.rs:9:37
  |
9 |     let _dir_guard = shell.push_dir(&ecosystem.link_to_code.join("prover"));
  |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ecosystem.link_to_code.join("prover")`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

@aon @popzxc @Deniallugo any idea?

Sorry, it's an update of rust compiler i'll fix it, you could ignore

[popzxc]

I've shared some thoughts on the subject elsewhere. In short, I would love to see what do we gain from this change (considering cons mentioned there) besides having strong typing as a fact.

[pbeza]

@popzxc, PTAL.

Re this: I reverted the changes related to adding the ENUM type for the status SQL column, but the rest of the code changes still seem relevant to me. Now, we only have enum TeeProofGenerationJobStatus in the Rust code:

zksync-era/core/lib/dal/src/tee_proof_generation_dal.rs

Lines 23 to 31 in 2ff41ad

	#[derive(Debug, EnumString, Display)]
	enum TeeProofGenerationJobStatus {
	#[strum(serialize = "unpicked")]
	Unpicked,
	#[strum(serialize = "picked_by_prover")]
	PickedByProver,
	#[strum(serialize = "generated")]
	Generated,
	}

just like we have enum ProofGenerationJobStatus in proof_generation_dal.rs:

zksync-era/core/lib/dal/src/proof_generation_dal.rs

Lines 20 to 30 in 46a75d4

	#[derive(Debug, EnumString, Display)]
	enum ProofGenerationJobStatus {
	#[strum(serialize = "unpicked")]
	Unpicked,
	#[strum(serialize = "picked_by_prover")]
	PickedByProver,
	#[strum(serialize = "generated")]
	Generated,
	#[strum(serialize = "skipped")]
	Skipped,
	}

I also aligned with the unpicked status introduced by @Artemka374 in #2258. Not sure why he didn’t convert ready_to_be_proven to unpicked in the migration script, though (like I did). 🤔

[popzxc]

@perekopskiy could you PTAL?

[perekopskiy]

nit: it's not chore but rather refactor