Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(zk_toolbox): add fees integration test to toolbox #2898

Merged
merged 56 commits into from
Sep 30, 2024
Merged

feat(zk_toolbox): add fees integration test to toolbox #2898

merged 56 commits into from
Sep 30, 2024

Conversation

manuelmauro
Copy link
Contributor

@manuelmauro manuelmauro commented Sep 17, 2024 •
edited
Loading

What ❔

Add fees integration test to toolbox and CI.

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@Deniallugo Deniallugo requested a review from a team as a code owner September 26, 2024 09:47
sanekmelnikov
sanekmelnikov reviewed Sep 26, 2024
View reviewed changes
core/tests/ts-integration/src/context-owner.ts Outdated Show resolved Hide resolved
core/tests/ts-integration/src/utils.ts Outdated Show resolved Hide resolved
core/tests/ts-integration/src/utils.ts Outdated Show resolved Hide resolved
etc/utils/src/kill.ts Outdated Show resolved Hide resolved
core/tests/ts-integration/tests/fees.test.ts Outdated Show resolved Hide resolved
core/tests/ts-integration/src/context-owner.ts Show resolved Hide resolved
core/tests/ts-integration/src/utils.ts Outdated Show resolved Hide resolved
@Deniallugo
Fix nits
f02b261 
Signed-off-by: Danil <deniallugo@gmail.com>
sanekmelnikov
sanekmelnikov previously approved these changes Sep 27, 2024
View reviewed changes
@Deniallugo
Fix logs place
fb31b2d 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
Run all fee tests
1cec206 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
Fix multiple chains for fees
77e8814 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
Merge branch 'main' into manuel-add-ts-integration-fees-test-to-toolbox
1a47104
@Deniallugo
Add no deps
4028d35 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
add logs
c89b351 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo Deniallugo added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit e7ead76 Sep 30, 2024
41 checks passed
@Deniallugo Deniallugo deleted the manuel-add-ts-integration-fees-test-to-toolbox branch September 30, 2024 12:07
This was referenced Sep 30, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrst88 alexandrst88 alexandrst88 approved these changes

@Deniallugo Deniallugo Deniallugo approved these changes

@sanekmelnikov sanekmelnikov sanekmelnikov left review comments

@yorik yorik Awaiting requested review from yorik yorik is a code owner automatically assigned from matter-labs/devops

@artmakh artmakh Awaiting requested review from artmakh artmakh is a code owner automatically assigned from matter-labs/devops

@hatemosphere hatemosphere Awaiting requested review from hatemosphere hatemosphere is a code owner automatically assigned from matter-labs/devops

@onyxet onyxet Awaiting requested review from onyxet onyxet is a code owner automatically assigned from matter-labs/devops

@otani88 otani88 Awaiting requested review from otani88 otani88 is a code owner automatically assigned from matter-labs/devops

@iluwaa iluwaa Awaiting requested review from iluwaa iluwaa is a code owner automatically assigned from matter-labs/devops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manuelmauro @sanekmelnikov @Deniallugo @alexandrst88