docs(zkstack_cli): update docs to mention foundry zksync #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelmauro
force-pushed
the
manuel-update-docs-to-mention-foundry-zksync
branch
from
8dc044e to
bb58441
Compare
Deniallugo
reviewed
Oct 23, 2024
|
Could you please cover https://github.com/matter-labs/zksync-era/tree/main/prover/docs as well? Especially https://github.com/matter-labs/zksync-era/blob/main/prover/docs/03_launch.md. |
matias-gonz
reviewed
Oct 23, 2024
Co-authored-by: Sarah Schwartz <58856580+sarahschwartz@users.noreply.github.com>
Co-authored-by: Sarah Schwartz <58856580+sarahschwartz@users.noreply.github.com>
Co-authored-by: Sarah Schwartz <58856580+sarahschwartz@users.noreply.github.com>
Co-authored-by: Sarah Schwartz <58856580+sarahschwartz@users.noreply.github.com>
Co-authored-by: Sarah Schwartz <58856580+sarahschwartz@users.noreply.github.com>
Co-authored-by: Sarah Schwartz <58856580+sarahschwartz@users.noreply.github.com>
Thank you! @sarahschwartz |
Deniallugo
reviewed
Nov 11, 2024
uF4No
reviewed
Nov 11, 2024
uF4No
reviewed
Nov 11, 2024
Co-authored-by: Antonio <tonioufa@gmail.com>
|
@Deniallugo I went through the whole dev-setup process within the VM you provided and everything worked just fine! |
Deniallugo
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Update docs to mention foundry zksync, and other changes to the CLI.
Why ❔
Checklist
zkstack dev fmtandzkstack dev lint.