Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(utils): Recombobulate utils crate #3237

Merged
merged 15 commits into from
Nov 11, 2024
Merged

refactor(utils): Recombobulate utils crate #3237

merged 15 commits into from
Nov 11, 2024

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Nov 8, 2024 •
edited
Loading

What ❔

  • Moves some of functionality of the utils crate to basic_types, such as conversions, div_ceil_u256, and serde_wrappers.
  • Inlines time-related utils at call sites (mostly the state keeper).

Why ❔

  • utils has moderately heavyweight deps (tokio, reqwest), which are not necessary for basic functionality.
  • Basic functionality better fits in basic_types by domain.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@slowli slowli marked this pull request as ready for review November 8, 2024 12:54
popzxc
popzxc previously approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Detected VM performance changes

Benchmark name Est. cycles Change in est. cycles
deploy_simple_contract/legacy 54011286 +2.1%

@slowli slowli added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit cce765b Nov 11, 2024
44 checks passed
@slowli slowli deleted the aov-pla-1064-recombobulate-utils-crate branch November 11, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perekopskiy perekopskiy perekopskiy approved these changes

@popzxc popzxc popzxc left review comments

@Deniallugo Deniallugo Awaiting requested review from Deniallugo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slowli @popzxc @perekopskiy