Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix a large number of link errors in the document #3388

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

diegoawz
Copy link
Contributor

What ❔

Fix a large number of link errors in the document

Why ❔

A large number of links contain errors, affecting developers' normal document reading. Fixing them will help improve the accuracy of the documentation and facilitate normal use by other developers

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@diegoawz
Copy link
Contributor Author

All the repaired links are now accessible, while the original links are all inaccessible.

popzxc
popzxc previously approved these changes Dec 16, 2024
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@popzxc
Copy link
Member

popzxc commented Dec 16, 2024

@diegoawz could you please run zkstack dev fmt to fix the formatting issues? After that we can merge the PR.

@diegoawz
Copy link
Contributor Author

@diegoawz could you please run zkstack dev fmt to fix the formatting issues? After that we can merge the PR.

Done

@popzxc
Copy link
Member

popzxc commented Dec 17, 2024

Looks like CI for lints is still failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants