Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Restore contract verification tests #419

Conversation

ly0va
Copy link
Member

@ly0va ly0va commented Nov 6, 2023

What ❔

  • restoring contract verification tests
  • bumping hardhat and hardhat-vyper

Why ❔

A bug in hardhat-vyper was fixed, hence we can compile vyper again.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@ly0va ly0va requested review from a team as code owners November 6, 2023 14:09
@ly0va ly0va force-pushed the lyova-evm-374-restore-contract-verification-test-after-hardhat-vyper-is branch from 664e022 to f810efa Compare November 7, 2023 01:11
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba88f67) 35.85% compared to head (f810efa) 35.88%.
Report is 6 commits behind head on main.

❗ Current head f810efa differs from pull request most recent head 2211946. Consider uploading reports for the commit 2211946 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
+ Coverage   35.85%   35.88%   +0.02%     
==========================================
  Files         519      519              
  Lines       27828    27828              
==========================================
+ Hits         9978     9985       +7     
+ Misses      17850    17843       -7     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ly0va ly0va enabled auto-merge November 7, 2023 08:55
@ly0va ly0va added this pull request to the merge queue Nov 8, 2023
Merged via the queue into main with commit 283096c Nov 8, 2023
21 checks passed
@ly0va ly0va deleted the lyova-evm-374-restore-contract-verification-test-after-hardhat-vyper-is branch November 8, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants