feat(en): Make reorg detector work with pruned data #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g., propagate errors instead of panicking
tomg10
previously approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Fantastic job! the only discussion I would probably want to have is whether we want to reuse test mocks (I think we definitely should!). I also added a few small comments, but they are rather small suggestions for improvement than anything that must be addressed.
…ector-work-with-pruned-data
slowli
deleted the
aov-pla-706-snapshot-recovery-make-reorg-detector-work-with-pruned-data
branch
RomanBrodetski
pushed a commit
that referenced
this pull request
Dec 25, 2023
🤖 I have created a release *beep* *boop* --- ## [18.10.0](core-v18.9.0...core-v18.10.0) (2023-12-25) ### Features * **api:** Add metrics for `jsonrpsee` subscriptions ([#733](#733)) ([39fd71c](39fd71c)) * **api:** remove jsonrpc backend ([#693](#693)) ([b3f0417](b3f0417)) * applied status snapshots dal ([#679](#679)) ([2e9f23b](2e9f23b)) * **en:** Make reorg detector work with pruned data ([#712](#712)) ([c4185d5](c4185d5)) * Remove data fetchers ([#694](#694)) ([f48d677](f48d677)) * Remove zks_getConfirmedTokens method ([#719](#719)) ([9298b1b](9298b1b)) ### Bug Fixes * added waiting for prometheus to finish ([#745](#745)) ([eed330d](eed330d)) * **EN:** temporary produce a warning on pubdata mismatch with L1 ([#758](#758)) ([0a7a4da](0a7a4da)) * **prover:** Add logging for prover + WVGs ([#723](#723)) ([d7ce14c](d7ce14c)) * remove leftovers after [#693](#693) ([#720](#720)) ([e93aa35](e93aa35)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Modifies reorg detector so that it works with pruned node data during snapshot recovery.
Why ❔
Part of preparations of EN code to support snapshot recovery.
Checklist
zk fmtandzk lint.cargo spellcheck --cfg=./spellcheck/era.cfg --code 1.