feat(en): Make consistency checker work with pruned data #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
commented
Dec 22, 2023
...lib/zksync_core/src/consistency_checker/tests/commit_l1_batch_351000-351004_mainnet.calldata
Outdated
Show resolved
Hide resolved
popzxc
reviewed
Jan 2, 2024
RomanBrodetski
previously approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Looks great! Regarding the Bail/Log: we want to bring Bail back, but to do this we need to fix the method that generates pubdata on the server. @mm-zk already found the fundamental issue, but we didn;t change the method yet. Note that this method is not used anymore on the main node - we take the DB value instead
popzxc
previously approved these changes
Jan 4, 2024
...and fix hang-up on pre-Boojum batches
popzxc
approved these changes
Jan 5, 2024
slowli
deleted the
aov-pla-705-snapshot-recovery-make-consistency-checker-work-with-pruned
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 5, 2024
🤖 I have created a release *beep* *boop* --- ## [19.0.0](core-v18.13.0...core-v19.0.0) (2024-01-05) ### ⚠ BREAKING CHANGES * **vm:** Release v19 - remove allowlist ([#747](#747)) ### Features * **en:** Make consistency checker work with pruned data ([#742](#742)) ([ae6e18e](ae6e18e)) * **eth_sender:** Remove generic bounds on L1TxParamsProvider in EthSender ([#799](#799)) ([29a4f52](29a4f52)) * **merkle tree:** Finalize metadata calculator snapshot recovery logic ([#798](#798)) ([c83db35](c83db35)) * **prover:** Remove circuit-synthesizer ([#801](#801)) ([1426b1b](1426b1b)) * **prover:** Remove old prover ([#810](#810)) ([8be1925](8be1925)) * **snapshot creator:** Make snapshot creator fault-tolerant ([#691](#691)) ([286c7d1](286c7d1)) * **vm:** Add boojum integration folder ([#805](#805)) ([4071e90](4071e90)) * **vm:** Make utils version-dependent ([#809](#809)) ([e5fbcb5](e5fbcb5)) * **vm:** Release v19 - remove allowlist ([#747](#747)) ([0e2bc56](0e2bc56)) * **vm:** Separate boojum integration vm ([#806](#806)) ([61712a6](61712a6)) ### Bug Fixes * **db:** Fix parsing statement timeout from env ([#818](#818)) ([3f663ec](3f663ec)) * **prover:** Remove old prover subsystems tables ([#812](#812)) ([9d0aefc](9d0aefc)) * **prover:** Remove prover-utils from core ([#819](#819)) ([2ceb911](2ceb911)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: EmilLuta <EmilLuta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Modifies consistency checker so that it works with pruned node data during snapshot recovery. Adds tests for the checker.
Why ❔
Part of preparations of EN code to support snapshot recovery.
Checklist
zk fmtandzk lint.cargo spellcheck --cfg=./spellcheck/era.cfg --code 1.