Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Forbid unstable features for the core workspace #990

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

popzxc
Copy link
Member

@popzxc popzxc commented Feb 1, 2024

What ❔

Adds a flag to clippy in zk lint to check for unstable features in the core workspace.

Why ❔

We're only using nightly in core workspace temporary, and unstable features would make it harder to migrate back to stable later.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@popzxc popzxc enabled auto-merge February 1, 2024 11:00
@popzxc popzxc added this pull request to the merge queue Feb 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 1, 2024
@popzxc popzxc added this pull request to the merge queue Feb 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 1, 2024
@EmilLuta EmilLuta added this pull request to the merge queue Feb 1, 2024
@EmilLuta
Copy link
Contributor

EmilLuta commented Feb 1, 2024

The add to queue, remove from queue dance begins...

Merged via the queue into main with commit 00d7f98 Feb 1, 2024
37 checks passed
@EmilLuta EmilLuta deleted the popzxc-forbid-unstable-features branch February 1, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants