Initial commit #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackHamer09
requested changes
Aug 26, 2024
JackHamer09
previously requested changes
Aug 26, 2024
|
I pushed SDK and Gateway but didn't add any CI logic yet, I think we can do it a bit later cause need to figure out how tests should be set up to work together |
JackHamer09
approved these changes
Aug 27, 2024
Expecting this to be a monorepo, and while there are still missing pieces for the contracts, most of the components are there.
set up to run CI for a folder hardhat already has caching, so had to specify some folders for nx so it knows where to look to avoid duplicating hard-hats de-deduplication
Update in root and in contracts
Also import latest lockfile from main, as local was outdated and inconsistent (the latest package versions have breaking changes)
Use workspace versions instead, we'll see if this by default installs packages or if there's another step for that
Based on PR feedback for where other packages are going
The peer dep conflict with openzepplin still exists, but other devs on the project prefer the default package manager since we're not yet large enough to need the smaller package footprints of pnpm. Tests should now run in CI again!
Also pass arguments correctly to nx with npm, as it needs the split between arguments to npm and arguments to nx
might be giving zksolc corruption issues that don't happen locally Updating packages as well!
Updating lockfile with latest tested versions (from the other repo)
We've exceeded the free plan and instead of falling back to gh actions it just fails
Still assuming something with the caching wrapper is breaking it, as the other repo with the onchain job downloads just fine.
Because npm won't auto alias to scripts unlike most other custom package mangers
It's looking like the download isn't designed to be multi-process safe! Because the test step includes a build, the download was being run twice.
Fails with gas limit, will debug in tests instead of setup
cpb8010
force-pushed
the
contracts-folder
branch
from
4151730 to
c92d56e
Compare
aon
added a commit
that referenced
this pull request
Jan 30, 2025
feat: add function to retrieve guarded accounts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import the state of the world from my example application
Also use nx and pnpm to setup monorepo tooling for other PRs