-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Session key module #99
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visit the preview URL for this PR (updated for commit 1a5d231): https://zksync-auth-server-staging--pr99-lyova-session-keys-m-0vaa18v6.web.app (expires Thu, 07 Nov 2024 18:25:34 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7 |
ly0va
force-pushed
the
lyova-session-keys-module
branch
from
October 23, 2024 19:39
eabba1f
to
42d54dd
Compare
3 tasks
Don't you love it when you change a comment and the whole contract bytecode changes, so it gets deployed to a different address via create2 and now you have to edit that address again?
MexicanAce
reviewed
Oct 30, 2024
packages/gateway/components/views/confirmation/RequestSession.vue
Outdated
Show resolved
Hide resolved
MexicanAce
reviewed
Oct 31, 2024
MexicanAce
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
block.timestamp
asserter for AA zksync-era#3031] add support for checking timestamps during validation Addblock.timestamp
assertions into Session Key Module #119Can be done later: