Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session key module #99

Merged
merged 39 commits into from
Oct 31, 2024
Merged

Session key module #99

merged 39 commits into from
Oct 31, 2024

Conversation

ly0va
Copy link
Member

@ly0va ly0va commented Oct 16, 2024

Can be done later:

Copy link

github-actions bot commented Oct 16, 2024

Visit the preview URL for this PR (updated for commit 1a5d231):

https://zksync-auth-server-staging--pr99-lyova-session-keys-m-0vaa18v6.web.app

(expires Thu, 07 Nov 2024 18:25:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7

@ly0va ly0va force-pushed the lyova-session-keys-module branch from eabba1f to 42d54dd Compare October 23, 2024 19:39
@ly0va ly0va linked an issue Oct 28, 2024 that may be closed by this pull request
3 tasks
ly0va added 7 commits October 30, 2024 14:46
Don't you love it when you change a comment and the whole
contract bytecode changes, so it gets deployed to a different
address via create2 and now you have to edit that address again?
@ly0va ly0va marked this pull request as ready for review October 30, 2024 15:32
packages/contracts/src/ClaveAccount.sol Show resolved Hide resolved
packages/contracts/src/managers/ValidatorManager.sol Outdated Show resolved Hide resolved
packages/sdk/tsconfig.base.json Outdated Show resolved Hide resolved
packages/demo-app/pages/index.vue Show resolved Hide resolved
packages/sdk/src/client/actions/session.ts Outdated Show resolved Hide resolved
packages/sdk/src/client/actions/account.ts Show resolved Hide resolved
packages/gateway/stores/requests.ts Show resolved Hide resolved
Copy link
Contributor

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@ly0va ly0va merged commit c36c334 into main Oct 31, 2024
@ly0va ly0va deleted the lyova-session-keys-module branch October 31, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement SessionKeyValidator logic
2 participants