Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auth server and sdk when not using sessions #45

Merged
merged 6 commits into from
Dec 22, 2024

Conversation

MexicanAce
Copy link
Contributor

Description

The use of SSO accounts without sessions is currently broken for users. Here's the fixes in this PR:

  1. Creating an account without sessions in the Auth Server will now properly navigate to the final confirmation screen
  2. Creating an account with a session will now display Create (instead of Connect) for the confirmation button
  3. Using a paymaster with Passkey Clients now works

Additional context

As part of this, I added a generic paymaster to the demo-app and updated the UI to have buttons for connecting with and without a session, also transferring 0.1 ETH with and without a paymaster.

New landing page:
image

Once connected:
image

I've also added deployment scripts to the paymaster using zksync-foundry. This feels like the best way to include contracts into front-end apps without creating an entirely new project.

Note: I am generating a forge-output.json file every time we deploy the generic paymaster, and using that in the demo-app

Copy link

github-actions bot commented Dec 21, 2024

Visit the preview URL for this PR (updated for commit 27f99b3):

https://zksync-auth-server-staging--pr45-nmv-address-issues-w-y5kawz67.web.app

(expires Sat, 28 Dec 2024 22:55:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7

@JackHamer09 JackHamer09 merged commit b9afdc3 into main Dec 22, 2024
7 checks passed
@JackHamer09 JackHamer09 deleted the nmv/address-issues-without-sessions branch December 22, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants