fix: detect reverted withdrawal transactions #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montekki
requested review from
AnastasiiaVashchuk,
Deniallugo and
haraldh
as code owners
Deniallugo
reviewed
Nov 8, 2023
Deniallugo
approved these changes
Nov 8, 2023
…nsactions-that-were-reverted
montekki
deleted the
fvs-pla-650-withdrawal-finalizer-ignores-transactions-that-were-reverted
branch
montekki
pushed a commit
that referenced
this pull request
Nov 9, 2023
🤖 I have created a release *beep* *boop* --- ## [0.2.5](v0.2.4...v0.2.5) (2023-11-09) ### Bug Fixes * detect reverted withdrawal transactions ([#287](#287)) ([ccd3777](ccd3777)) * Update CONTRIBUTING.md ([#291](#291)) ([5ec9570](5ec9570)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This detects withdrawal transactions that have been reverted and adds these withdrawals to the retry set.
Why ❔
If something goes down and the transaction is reverted it was considered successful.
Checklist