-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix useHasPermission minimumRole cascade check #3949
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbishel
approved these changes
Oct 6, 2022
sbishel
added
the
CherryPick/Approved
Meant for the quality or patch release tracked in the milestone
label
Oct 6, 2022
Cherry pick is scheduled. |
Error trying doing the automated Cherry picking. Please do this manually
|
mattermost-build
pushed a commit
to mattermost-build/focalboard
that referenced
this pull request
Oct 6, 2022
/cherry-pick release-7.4 |
Cherry pick is scheduled. |
mattermost-build
pushed a commit
to mattermost-build/focalboard
that referenced
this pull request
Oct 6, 2022
mattermod
added
CherryPick/Done
Successfully cherry-picked to the quality or patch release tracked in the milestone
and removed
CherryPick/Approved
Meant for the quality or patch release tracked in the milestone
labels
Oct 6, 2022
sbishel
pushed a commit
that referenced
this pull request
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2: Dev Review
Requires review by a core committer
CherryPick/Done
Successfully cherry-picked to the quality or patch release tracked in the milestone
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the permission cascade check for
minimumRole
Ticket Link
#3945