Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix useHasPermission minimumRole cascade check #3949

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

mgdelacroix
Copy link
Contributor

Summary

This PR fixes the permission cascade check for minimumRole

Ticket Link

#3945

@mgdelacroix mgdelacroix added the 2: Dev Review Requires review by a core committer label Oct 6, 2022
@mgdelacroix mgdelacroix added this to the v7.3 milestone Oct 6, 2022
@mgdelacroix mgdelacroix requested a review from sbishel October 6, 2022 15:42
@sbishel sbishel added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Oct 6, 2022
@sbishel sbishel merged commit 2f90840 into main Oct 6, 2022
@mattermod
Copy link
Contributor

Cherry pick is scheduled.

@sbishel sbishel deleted the fix-minimum-role-use-has-permission branch October 6, 2022 15:57
@mattermod
Copy link
Contributor

Error trying doing the automated Cherry picking. Please do this manually

+++ Updating remotes...
Fetching upstream
Failed to add the RSA host key for IP address '140.82.112.3' to the list of known hosts (/app/.ssh/known_hosts).
From github.com:mattermost/focalboard
   7f3fcae9..7a3dd2c2  boards-as-persisted-category -> upstream/boards-as-persisted-category
   2c27d262..2f90840a  main        -> upstream/main
 * [new branch]        release-7.4 -> upstream/release-7.4
Fetching origin
Failed to add the RSA host key for IP address '140.82.114.4' to the list of known hosts (/app/.ssh/known_hosts).
+++ Updating remotes done...
+++ Creating local branch automated-cherry-pick-of-focalboard-#3949-upstream-release-7.3-1665071856
Switched to a new branch 'automated-cherry-pick-of-focalboard-#3949-upstream-release-7.3-1665071856'
Branch 'automated-cherry-pick-of-focalboard-#3949-upstream-release-7.3-1665071856' set up to track remote branch 'release-7.3' from 'upstream'.

+++ About to attempt cherry pick of PR #3949 with merge commit 2f90840ae867c1b67aac58de386f3ce8d002167a.

[automated-cherry-pick-of-focalboard-#3949-upstream-release-7.3-1665071856 802c4ec0] Fix useHasPermission minimumRole cascade check (#3949)
 Author: Miguel de la Cruz <miguel@mcrx.me>
 Date: Thu Oct 6 17:57:33 2022 +0200
 1 file changed, 2 insertions(+), 2 deletions(-)

+++ I'm about to do the following to push to GitHub (and I'm assuming origin is your personal fork):

  git push origin automated-cherry-pick-of-focalboard-#3949-upstream-release-7.3-1665071856:automated-cherry-pick-of-focalboard-#3949-upstream-release-7.3

Failed to add the RSA host key for IP address '140.82.114.4' to the list of known hosts (/app/.ssh/known_hosts).
remote: 
remote: Create a pull request for 'automated-cherry-pick-of-focalboard-#3949-upstream-release-7.3' on GitHub by visiting:        
remote:      https://github.com/mattermost-build/focalboard/pull/new/automated-cherry-pick-of-focalboard-%233949-upstream-release-7.3        
remote: 
To github.com:mattermost-build/focalboard.git
 * [new branch]        automated-cherry-pick-of-focalboard-#3949-upstream-release-7.3-1665071856 -> automated-cherry-pick-of-focalboard-#3949-upstream-release-7.3

+++ Creating a pull request on GitHub at mattermost-build:automated-cherry-pick-of-focalboard-#3949-upstream-release-7.3
Error creating pull request: Unprocessable Entity (HTTP 422)
Invalid value for "base"

+++ Returning you to the main branch and cleaning up.

mattermost-build pushed a commit to mattermost-build/focalboard that referenced this pull request Oct 6, 2022
@sbishel
Copy link
Collaborator

sbishel commented Oct 6, 2022

/cherry-pick release-7.4

@mattermod
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit to mattermost-build/focalboard that referenced this pull request Oct 6, 2022
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Oct 6, 2022
sbishel pushed a commit that referenced this pull request Oct 6, 2022
(cherry picked from commit 2f90840)

Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants