-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitize user following config for ShowFullName and ShowEmailAddress #4820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mgdelacroix any idea why the tests are failing? |
Is there a way to check from the plugin if the requesting user is the System Admin? Because currently the fix is indeed correct but it also applies to System Admins whereas it shouldn't. These two settings don't apply to system admins. |
@enahum tests are failing because we're calling
I'd suggest to create the config directly as you're only going to use those two properties, so there is no need to fill the rest of the values |
@mgdelacroix thanks. Any idea on how to check if the user is an admin? |
@esarafianou @enahum I think the best path forward is to do the same we're doing in |
Sure, but how do I determine if the user is a sysadmin? |
@enahum same as we do in channels, we can use the permissions service to check if the user is an admin through the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cherry-pick release-7.11 |
Cherry pick is scheduled. |
…attermost-community#4820) (cherry picked from commit 3625c53)
…of-focalboard-#4820-upstream-release-7.11 Automated cherry pick of #4820
/cherry-pick release-7.10 |
/cherry-pick release-7.8 |
Cherry pick is scheduled. |
…attermost-community#4820) (cherry picked from commit 3625c53)
Cherry pick is scheduled. |
Error trying doing the automated Cherry picking. Please do this manually
|
…attermost-community#4820) (cherry picked from commit 3625c53)
…of-focalboard-#4820-upstream-release-7.10 Automated cherry pick of #4820
Ticket Link
https://mattermost.atlassian.net/browse/MM-53190