InsertBlock per workspace logic #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenilim
requested review from
sbishel and
hahmadia
and removed request for
a team
hahmadia
approved these changes
Jul 24, 2021
|
FYI @harshilsharma63, @sbishel, @jespino. I found this as an issue on the community server, and will cherry-pick this fix to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the InsertBlock logic to insert per workspace. This was changed in PR #583, and due to that change, blocks with the same ID in different workspaces would fail to update. It also exposes a security hole where the workspace of a block can be changed by an insert.
Currently, the primary key of a block is WorkspaceID+ID. If / when we change that, we will need to change it across the DB store system.