Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing CSS vars #949

Merged
merged 3 commits into from
Aug 12, 2021
Merged

Fixed missing CSS vars #949

merged 3 commits into from
Aug 12, 2021

Conversation

harshilsharma63
Copy link
Member

Summary

Updated some old CSS variables to the new ones.

Ticket Link

Fixes #938

@harshilsharma63 harshilsharma63 requested a review from a team as a code owner August 12, 2021 08:23
@harshilsharma63 harshilsharma63 requested review from jespino, hahmadia and sbishel and removed request for a team, jespino and hahmadia August 12, 2021 08:23
@jespino jespino added the 3: Reviews Complete All reviewers have approved the pull request label Aug 12, 2021
@jespino jespino removed the request for review from sbishel August 12, 2021 08:24
@jespino
Copy link
Contributor

jespino commented Aug 12, 2021

@harshilsharma63 you need to regenerate the snapshots.

@jespino jespino added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Aug 12, 2021
@harshilsharma63
Copy link
Member Author

@harshilsharma63 you need to regenerate the snapshots.

Yup, done 👍

@harshilsharma63 harshilsharma63 merged commit 3a7747b into main Aug 12, 2021
@harshilsharma63 harshilsharma63 deleted the gh-938 branch August 12, 2021 09:59
harshilsharma63 added a commit that referenced this pull request Aug 12, 2021
* Fixed missing css vars

* Updated snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request CherryPick/Approved Meant for the quality or patch release tracked in the milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Table Calculations -> Calculation Row should not be included in scroll.
2 participants