[MI-1974] Add modal to link a project #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayusht2810
requested review from
Kshitij-Katiyar,
raghavaggarwal2308,
avas27JTG and
manojmalik20
raghavaggarwal2308
requested changes
Aug 1, 2022
|
|
||
| // Make POST api request | ||
| usePlugin.makeApiRequest(Constants.pluginApiServiceConfigs.createLink.apiServiceName, payload); | ||
| }, [state, linkOrganizationError, linkProjectError]); |
There was a problem hiding this comment.
Do we need linkOrganizationError, linkProjectError these two here?
There was a problem hiding this comment.
using a different approach to store error now
server/store/utils.go
Outdated
| return base64.StdEncoding.EncodeToString(hash.Sum(nil)) | ||
| } | ||
|
|
||
| func ProjectListFromJSON(bytes []byte) (*ProjectList, error) { |
There was a problem hiding this comment.
This should not be in utils.go folder it is a serializer
There was a problem hiding this comment.
moved to the file where its struct is present
raghavaggarwal2308
approved these changes
Aug 1, 2022
Kshitij-Katiyar
approved these changes
Aug 1, 2022
…ure-devops into MI-1974
avas27JTG
approved these changes
Aug 10, 2022
avas27JTG
added a commit
that referenced
this pull request
Aug 10, 2022
* [MI-1846]: Added nvmrc file * Modular folder structure * Modular folder structure * [MI-1846]: Base setup * [MI-1846]: Refactored server base setup * [MI-1854]: Implement OAuth to access Azure DevOps services * working * [MI-1846]: Review fixes * [MI-1931] Add API to get projects and get tasks * [MI-1931] Self review fixes * [MI-1931] Review fixes 1 * [MI-1931] Self review fix * [MI-1945] Add function to make protected routes * [MI-1948] Add API to create task * [MI-1931] Review fixes 2 * [MI-1931] Add json error handling * [MI-1948] Add error in json format * [MI-1948_1] Resolve build error * [MI-1964]: Make changes to make POST API request from the webapp. * [MI-1846]: Review fixes * [MI-1854]: Review fixes * [MI-1854]: Removed unused config * [MI-1854]: Added logic to verify state * [MI-1953] Add create task modal (#6) * [MI-1953] Add create task modal * [MI-1953] Run fmt * [MI-1953] Correct validations * [MI-1953] Send new work item link in DM * [MI-1953] Correct error handling and reusable components * [MI-1953] Correct operator in modal footer * [MI-1953] Disable button on API request * [MI-1953] Correct loading state * [MI-1953] Review fixes Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com> * [MI-1950] Add feature to preview work items (#7) * [MI-1953] Add create task modal * [MI-1953] Run fmt * [MI-1950] Add feature to preview work items * [MI-1950] Self review fix * [MI-1953] Correct validations * [MI-1950] Self review fix * [MI-1953] Send new work item link in DM * [MI-1950] Add a comment * [MI-1950] Review fixes 1 * [MI-1950] Review fix * [MI-1953] Correct error handling and reusable components * [MI-1950] Update variable names * [MI-1953] Correct operator in modal footer * [MI-1953] Disable button on API request * [MI-1953] Correct loading state * [MI-1950] Using slack attachment to show preview * [MI-1950] Correct comments * [MI-1950]: Sync Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com> * [MI-1979]: Created project list RHS view and related components (#8) * [MI-1953] Add create task modal * [MI-1953] Run fmt * [MI-1950] Add feature to preview work items * [MI-1950] Self review fix * [MI-1953] Correct validations * [MI-1950] Self review fix * [MI-1953] Send new work item link in DM * [MI-1950] Add a comment * [MI-1979]: Created project list RHS view and realted components * [MI-1979]: Fixed lints * [MI-1979]: Review fixes * [MI-1979]: Review fixes * [MI-1979]: Removed unused code Co-authored-by: ayusht2810 <ayush.thakur@joshtechnologygroup.com> Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com> * [MI-1983]: Create subscription details with related components and ad… (#9) * [MI-1953] Add create task modal * [MI-1953] Run fmt * [MI-1950] Add feature to preview work items * [MI-1950] Self review fix * [MI-1953] Correct validations * [MI-1950] Self review fix * [MI-1953] Send new work item link in DM * [MI-1950] Add a comment * [MI-1979]: Created project list RHS view and realted components * [MI-1979]: Fixed lints * [MI-1983]: Create subscription details with related components and add redux logic to navigate. * [MI-1983]: Changed hover state * [MI-1983]: Review fixes Co-authored-by: ayusht2810 <ayush.thakur@joshtechnologygroup.com> Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com> * [MI-1974] Add modal to link a project (#11) * [MI-1953] Add create task modal * [MI-1953] Run fmt * [MI-1953] Correct validations * [MI-1953] Send new work item link in DM * [MI-1974] Add feature to link a project * [MI-1953] Correct error handling and reusable components * [MI-1953] Correct operator in modal footer * [MI-1974] Refactor KV store * [MI-1953] Disable button on API request * [MI-1974] Run fmt and correct loading * [MI-1974] Add error field in modal * [MI-1974] Review fixes * [MI-1974] Add function to check if project is already linked Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com> * [MI-1989] Add middleware to check oAuth (#12) * [MI-1953] Add create task modal * [MI-1953] Run fmt * [MI-1953] Correct validations * [MI-1953] Send new work item link in DM * [MI-1953] Correct error handling and reusable components * [MI-1953] Correct operator in modal footer * [MI-1953] Disable button on API request * [MI-1989] Add middleware to check oAuth * [MI-1989] Correct function call Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com> * [MI-1993] Correct failing CI (#13) * [MI-1953] Add create task modal * [MI-1953] Run fmt * [MI-1953] Correct validations * [MI-1953] Send new work item link in DM * [MI-1953] Correct error handling and reusable components * [MI-1953] Correct operator in modal footer * [MI-1953] Disable button on API request * [MI-1953] Correct loading state * [MI-1993] Correct ci * [MI-1993] Correct if else chain * [MI-1993] Correct make test * [MI-1993] Correct error handling * [MI-1993]: Review fixes * [MI-1993]: Review fixes Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com> Co-authored-by: ayusht2810 <ayush.thakur@joshtechnologygroup.com> Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com> Co-authored-by: ayusht2810 <100013900+ayusht2810@users.noreply.github.com>
avas27JTG
pushed a commit
that referenced
this pull request
Jan 6, 2023
[MI-2462] Moved files in assets to public folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.