[MI-1987]: Integrated project list UI with: #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure-devops into MI-1854_1
…azure-devops into epic_av
…d redux logic to navigate.
…ure-devops into MI-1987
…ure-devops into MI-1986
muazzamqazi
reviewed
Jul 28, 2022
muazzamqazi
reviewed
Jul 28, 2022
| height: 100%; | ||
| min-height: 350px; | ||
| display: flex; |
muazzamqazi
reviewed
Jul 28, 2022
muazzamqazi
approved these changes
Jul 28, 2022
ayusht2810
requested changes
Jul 28, 2022
| type TooltipProps = { | ||
| tooltipContent: JSX.Element | string | ||
| children: JSX.Element | ||
| placement?: Placement, |
There was a problem hiding this comment.
Suggested change
| placement?: Placement, | |
| placement?: Placement |
There was a problem hiding this comment.
not required as eslint is not checking this
Comment on lines
+8
to
+9
| text: string | ||
| slashCommand?: string |
There was a problem hiding this comment.
shouldn't we create a type for this?
There was a problem hiding this comment.
this will be used just here so need to create a separate type
|
Closing this PR and picked changes of this PR here Brightscout#28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated project list UI with:
Synced branches