Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-51250]: Added max limit for reading responses #147

Merged
merged 9 commits into from
Mar 21, 2023
Merged

[MM-51250]: Added max limit for reading responses #147

merged 9 commits into from
Mar 21, 2023

Conversation

avas27JTG
Copy link
Contributor

@avas27JTG avas27JTG commented Mar 13, 2023

See MM-51250

avas27JTG and others added 5 commits January 4, 2023 16:08
… to "Close" on filter popover. (#17) (#21)

* [MI-2504][webapp]: Changed Hide to Close on filter popover

* [MI-2504][server]: Generated manifest files

* [MI-2504][server]: Updated version in manifest

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
…API and fixed Boards update subscription. (#22)

* [MI-2505][server]: Added logic to protect subscriptions notification webhook API and fixed Boards update subscription.

* [MI-2505][MI-2518] Fix failing testcases

* [MI-2505]:Added webhook secret encoding and review fixes

* [MI-2505]:Added webhook secret encryption

* [MI-2505]: Fixed CI

* [MI-2505]: Reverted change of auth scopes

* [MI-2505]: Fixed CI

* [MI-2505][MI-2603] Fixed testcases

* [MI-2505]: Used constant for path

* [MI-2505]: Refinded message

* [MI-2505]: Minor review fixes

* [MI-2505][MI-2603] Review fix

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>
server/plugin/client.go Outdated Show resolved Hide resolved
@avas27JTG avas27JTG changed the title [MM-51250]: Fix for unbounded read in Azure DevOps API client [MM-51250]: Added max limit for reading response. Mar 14, 2023
@avas27JTG avas27JTG changed the title [MM-51250]: Added max limit for reading response. [MM-51250]: Added max limit for reading responses. Mar 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2023

Codecov Report

Patch coverage: 87.50% and project coverage change: +0.31 🎉

Comparison is base (2d2f0ab) 65.65% compared to head (8d3c30e) 65.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   65.65%   65.96%   +0.31%     
==========================================
  Files          15       15              
  Lines        3313     3317       +4     
==========================================
+ Hits         2175     2188      +13     
+ Misses       1013     1002      -11     
- Partials      125      127       +2     
Impacted Files Coverage Δ
server/plugin/client.go 71.91% <87.50%> (+2.68%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@avas27JTG avas27JTG changed the title [MM-51250]: Added max limit for reading responses. [MM-51250] Mar 14, 2023
@mickmister mickmister requested a review from srkgupta March 14, 2023 14:37
@m1lt0n m1lt0n requested a review from jupenur March 14, 2023 15:18
Copy link

@jupenur jupenur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test case would be nice to have. Otherwise LGTM.

@avas27JTG avas27JTG requested a review from m1lt0n March 15, 2023 14:22
@avas27JTG
Copy link
Contributor Author

added m1lt0n as non-blocking reviewer

@m1lt0n m1lt0n added the 4: Reviews Complete All reviewers have approved the pull request label Mar 15, 2023
@mickmister mickmister added this to the v2.2.2 milestone Mar 15, 2023
@avas27JTG
Copy link
Contributor Author

A test case would be nice to have. Otherwise LGTM.

Added a test case.

@avas27JTG avas27JTG changed the title [MM-51250] [MM-51250]: Added max limit for reading responses Mar 21, 2023
@hanzei hanzei merged commit 51e31f9 into master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants