generated from Brightscout/mattermost-plugin-starter-template
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MI-2035]: Integrated unlinking project from details page #33
Merged
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9f65a10
[MI-1986]: Create plugin API to fetch linked projects list
avas27JTG e1793e4
[MI-1987]: Integrated project list UI
avas27JTG 0110bdc
[MI-1987]: Review fixes
avas27JTG ff267f5
Merge branch 'master' of github.com:Brightscout/mattermost-plugin-azu…
avas27JTG 8dc6f80
[MI-2001]: [MI-2001]: Create plugin API to unlink project and integra…
avas27JTG 9637e82
[MI-2001]: Review fixes
avas27JTG 15cee42
[MI-2002]: Created plugin API to fetch user details and UI integratio…
avas27JTG 84397d0
[MI-2002]: Updated API paths
avas27JTG 5fb9155
[MI-2049]: Added websocket support to detect user connection details …
avas27JTG 283e1c2
[MI-2035]: Integrated unlinking project from details page
avas27JTG 7dc28e6
Merge branch 'master' of github.com:Brightscout/mattermost-plugin-azu…
avas27JTG bcccb9d
[MI-2035]: Review fix
avas27JTG 7b5bc53
[MI-2035]: Review fix
avas27JTG File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove the
useCallback
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need any caching here even when the callback dependency which would be
errorState
here is changed we need to perform all the logic present inside this funcso, I don't think it worth using that, what you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand. If the dependency
errorState
is not changing, then why do we need to perform all the logic inside the function?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad, I thought the submit button stays disabled when fields are invalidated so it will be enabled only when errors are resolved and that way we would be performing the logic only when the button is clicked this implies error fields are resolved
added callback, but we can enhance our UI to keep submit button disabled if there is any error in the form and no change is made
@sooraj-shukla you can also do this as this is a good practice, it's useless to keep the button enabled when form already have validation errors