[MI-2085]: No projects linked handling on modals and refactor create-… #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re-devops into MI-1987_1
…n with other changes
…and a centralised check for root modals
…azure-devops into MI-2085
ayusht2810
reviewed
Aug 25, 2022
| subTitle={{text: 'Create a subscription by clicking the button below'}} | ||
| buttonText='Create new subscription' | ||
| title='No subscriptions yet' | ||
| subTitle={{text: 'You can link a subscription by clicking the below button.'}} |
There was a problem hiding this comment.
Suggested change
| subTitle={{text: 'You can link a subscription by clicking the below button.'}} | |
| subTitle={{text: 'You can create a subscription by clicking the below button.'}} |
There was a problem hiding this comment.
yes, sounds good, however link is mentioned in Figma
There was a problem hiding this comment.
add sounds more appropriate as per Figma
…re-devops into MI-2085
ayusht2810
approved these changes
Sep 5, 2022
| @@ -215,7 +215,7 @@ func (c *client) call(basePath, method, path, contentType string, mattermostUser | |||
| req.Header.Add("Content-Type", contentType) | |||
| } | |||
|
|
|||
| if isAccessTokenExpired, refreshToken := c.plugin.isAccessTokenExpired(mattermostUserID); isAccessTokenExpired { | |||
| if IsAccessTokenExpired, refreshToken := c.plugin.IsAccessTokenExpired(mattermostUserID); IsAccessTokenExpired { | |||
There was a problem hiding this comment.
Suggested change
| if IsAccessTokenExpired, refreshToken := c.plugin.IsAccessTokenExpired(mattermostUserID); IsAccessTokenExpired { | |
| if isAccessTokenExpired, refreshToken := c.plugin.IsAccessTokenExpired(mattermostUserID); isAccessTokenExpired { |
There was a problem hiding this comment.
this is already fixed
|
these changes are synced with master where all the changes are already reviewed (1st and 2nd pass) for this PR the changes are too small for 2nd pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No projects linked handling on modals and refactor create-task-modal