Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter errors #89

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Fix linter errors #89

merged 1 commit into from
Nov 17, 2022

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Nov 3, 2022

Summary

Fix linter errors caused by golangci-lint update.

Ticket Link

None

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022

Codecov Report

Base: 65.73% // Head: 65.79% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (352bb6b) compared to base (dbd4089).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   65.73%   65.79%   +0.06%     
==========================================
  Files           5        5              
  Lines         534      535       +1     
==========================================
+ Hits          351      352       +1     
  Misses        131      131              
  Partials       52       52              
Impacted Files Coverage Δ
server/client.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hanzei hanzei added the Work In Progress Not yet ready for review label Nov 14, 2022
@hanzei hanzei requested a review from mickmister November 14, 2022 20:54
@hanzei hanzei marked this pull request as ready for review November 14, 2022 20:54
@hanzei hanzei requested a review from kosgrz as a code owner November 14, 2022 20:54
@hanzei hanzei added 2: Dev Review Requires review by a core committer Work In Progress Not yet ready for review and removed Work In Progress Not yet ready for review labels Nov 14, 2022
@hanzei
Copy link
Contributor Author

hanzei commented Nov 14, 2022

The PR fixes all linter issues expect the one discussed in https://community.mattermost.com/core/pl/au4rusy3mtfuik7e3mzosg9bur. Let's fix most of them and tackle the last one separately.

@hanzei hanzei added this to the v1.0.0 milestone Nov 14, 2022
@hanzei hanzei mentioned this pull request Nov 15, 2022
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Nov 17, 2022
@hanzei hanzei merged commit 8ca476c into master Nov 17, 2022
@hanzei hanzei deleted the fix_lint branch November 17, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants