Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-61] Use SiteURL for all calls from the webapp #93

Merged
merged 3 commits into from
Mar 21, 2023
Merged

[GH-61] Use SiteURL for all calls from the webapp #93

merged 3 commits into from
Mar 21, 2023

Conversation

Kshitij-Katiyar
Copy link
Contributor

Summary

@Kshitij-Katiyar @sanjaymj12345 @maisnamrajusingh
[MI-2506]:Fixed issue mattermost#61 of skype4business (#1)
d9b0203 
* add domain in client js file

* add url

* fixed lint issues

* updated lint issues

* updated style changes

* resolved comments , removed unwanted changes

* resolved comments

* resolved comments

* resolved comments

* resolved comments

* resolved comments

* resolved comments

* resolved comments

* [MI-2506]:Fixed issue mattermost-community#61 of skype4business

Co-authored-by: sanjay12345 <sanjaymj824@gmail.com>
Co-authored-by: Maisnam Raju Singh <85172229+maisnamrajusingh@users.noreply.github.com>
Co-authored-by: maisnamrajusingh <raju.s@demansol.com>
@mattermod
Copy link
Contributor

Hello @Kshitij-Katiyar,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2022 •
edited
Loading

Codecov Report

Base: 65.53% // Head: 65.53% // No change to project coverage 👍

Coverage data is based on head (d9b0203) compared to base (d106c33).
Patch has no changes to coverable lines.

❗ Current head d9b0203 differs from pull request most recent head 9c14c76. Consider uploading reports for the commit 9c14c76 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master      #93   +/-   ##
=======================================
  Coverage   65.53%   65.53%           
=======================================
  Files           5        5           
  Lines         531      531           
=======================================
  Hits          348      348           
  Misses        131      131           
  Partials       52       52

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mattermost-build
Copy link

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester and removed Lifecycle/1:stale labels Jan 31, 2023
@hanzei hanzei linked an issue Jan 31, 2023 that may be closed by this pull request
Use SiteURL for all calls from the webapp #61
Closed
javaguirre
javaguirre suggested changes Feb 1, 2023
View reviewed changes
Copy link

@javaguirre javaguirre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! some small details.

javaguirre
javaguirre approved these changes Feb 6, 2023
View reviewed changes
Copy link

@javaguirre javaguirre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@hanzei
Copy link
Contributor

hanzei commented Feb 15, 2023

/update-branch

@mattermost-build
Copy link

We don't have permissions to update this PR, please contact the submitter to apply the update.

@hanzei
Copy link
Contributor

hanzei commented Feb 15, 2023

@Kshitij-Katiyar Would you please merge master into your branch?

@Kshitij-Katiyar
Copy link
Contributor Author

@Kshitij-Katiyar Would you please merge master into your branch?

@hanzei synced with the master

@hanzei hanzei requested a review from DHaussermann February 21, 2023 11:52
@hanzei
Copy link
Contributor

hanzei commented Feb 21, 2023

@DHaussermann Would you mind testing the PR in release testing?

@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Feb 21, 2023
@hanzei hanzei added this to the v1.0.0 milestone Feb 21, 2023
@mattermost-build
Copy link

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@hanzei hanzei changed the title [GH-61]:Use SiteURL for all calls from the webapp [GH-61] Use SiteURL for all calls from the webapp Mar 21, 2023
@hanzei hanzei removed 3: QA Review Requires review by a QA tester Lifecycle/1:stale labels Mar 21, 2023
@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label Mar 21, 2023
@hanzei hanzei merged commit f515bf4 into mattermost-community:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javaguirre javaguirre javaguirre approved these changes

@mickmister mickmister mickmister approved these changes

@kosgrz kosgrz Awaiting requested review from kosgrz

@DHaussermann DHaussermann Awaiting requested review from DHaussermann

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Use SiteURL for all calls from the webapp
7 participants
@Kshitij-Katiyar @mattermod @codecov-commenter @mattermost-build @hanzei @javaguirre @mickmister