Fix potential timeout error on first job creation (#36)

mattermost · Aug 11, 2023 · 00a5750 · 00a5750
1 parent 8b86b3c
commit 00a5750
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/service/docker/service.go b/service/docker/service.go
@@ -149,6 +149,11 @@ func (s *JobService) CreateJob(cfg job.Config, onStopCb job.StopCb) (job.Job, er
 		return job.Job{}, fmt.Errorf("failed to update job runner: %w", err)
 	}
 
+	// We create a new context as updating the job runner could have taken more
+	// than dockerRequestTimeout.
+	ctx, cancel = context.WithTimeout(context.Background(), dockerRequestTimeout)
+	defer cancel()
+
 	var jobData recorder.RecorderConfig
 	jobData.FromMap(cfg.InputData)
 	jobData.SetDefaults()