[MM-53432] Refactor to support multiple job types #44
Conversation
streamer45
added
2: Dev Review
Makefile
Outdated
| @@ -41,8 +41,8 @@ DOCKER_REGISTRY_REPO ?= mattermost/${APP_NAME}-daily | |||
| DOCKER_USER ?= user | |||
| DOCKER_PASSWORD ?= password | |||
| ## Docker Images | |||
| DOCKER_IMAGE_GO += "golang:${GO_VERSION}@sha256:dd9ad81920b63c7f9f18823d888d5fdcc7e7516086fd16654d07bc437f0e2427" | |||
| DOCKER_IMAGE_GOLINT += "golangci/golangci-lint:v1.52.2@sha256:5fa6a92ab28ca3421c88d2b6cd794c9759d05a999aceca73053d014aad41b9d3" | |||
| DOCKER_IMAGE_GO += "golang:${GO_VERSION}@sha256:b17c35044f4062d83c815434615997eed97697daae8745c6dd39dc3673b87efb" | |||
There was a problem hiding this comment.
I ran into an issue with this today -- if we use a sha, does that mean you're pinning to a particular arch?
There was a problem hiding this comment.
Yeah, ideally we'd be using docker buildx given the way we are building is actually deprecated ( https://mattermost.atlassian.net/browse/MM-54412). That should also help with multi arch builds but will probably need some non trivial amount of work.
There was a problem hiding this comment.
Hmm... For now I just have to manually remove the sha's build on mac, it's a pain, but I guess sec wouldn't be happy if we removed them here, eh?
There was a problem hiding this comment.
They asked for pinning when possible, even though from a security perspective it kinda forces us to keep it up to date in case of security fixes upstream, so it's not that great. I guess build reproduction is a better reason for keeping these.
Manual patching is the quickest thing for now to unblock testing/development I suppose.
streamer45
added
3: Reviews Complete
* Update transcriber * Don't set defaults * Update Go image
streamer45
removed
the
Do Not Merge/Awaiting PR
Summary
PR slightly refactors the service to allow for different job types, namely post call transcriptions.
One important breaking change here is that we'll start using the more idiomatic (and generic)
/datavolume path from now on. This means we'll need to bump the minimum recorder image version to the latest once released.Ticket Link
https://mattermost.atlassian.net/browse/MM-53432