[MM-56184] Allow passing Kubernetes resource requirements to jobs #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpoile
approved these changes
Jan 8, 2024
streamer45
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to allow setting resource limits and requests for jobs we manage so that it's easier for Kubernetes to schedule them properly based on available nodes resources.
I kept the implementation simple to avoid redefining a bunch of K8S types. The downside is that we need to pass some potentially ugly JSON but the alternative seemed just a lot of repetition and potentially less powerful overall.
This is how it would look like to define specific limits and requests for both jobs we support today from a helm chart:
Again, thanks @gabrieljackson for the tip :)
Ticket Link
https://mattermost.atlassian.net/browse/MM-56184