Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-62338] Persist logs to scoped data path #76

Merged
merged 2 commits into from
Dec 20, 2024
Merged

[MM-62338] Persist logs to scoped data path #76

merged 2 commits into from
Dec 20, 2024

Conversation

streamer45
Copy link
Contributor

Summary

Two changes here:

  • We persist logs to the data path so they can be recovered in case of failure.
  • We scope the data path by job ID so that if the underlying storage is shared, we don't get into conflict issues and keep everything nicely tied.

Ticket Link

https://mattermost.atlassian.net/browse/MM-62338

@streamer45 streamer45 added the 2: Dev Review Requires review by a core committer label Dec 20, 2024
@streamer45 streamer45 added this to the v0.8.0 milestone Dec 20, 2024
@streamer45 streamer45 requested a review from cpoile December 20, 2024 16:05
@streamer45 streamer45 self-assigned this Dec 20, 2024
@streamer45 streamer45 mentioned this pull request Dec 20, 2024
Open
@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Dec 20, 2024
@streamer45 streamer45 merged commit f8b558b into master Dec 20, 2024
2 checks passed
@streamer45 streamer45 deleted the MM-62338 branch December 20, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpoile cpoile cpoile approved these changes

Assignees

@streamer45 streamer45

Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@streamer45 @cpoile