[MM-59866] Prevent failure if track context has no samples #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
commented
Jul 25, 2024
| @@ -181,7 +189,7 @@ func (t *Transcriber) processLiveTrack(track trackRemote, sessionID string) { | |||
| } | |||
|
|
|||
| var gap uint64 | |||
| if ctx.startTS == 0 { | |||
There was a problem hiding this comment.
Changing this since, in theory, startTS could be still 0 even after setting it the first time if we are very unlucky and the start time was set just now. Very unlikely but you never know :)
streamer45
commented
Jul 25, 2024
Comment on lines
+51
to
+59
| dir, err := os.MkdirTemp("", "data") | ||
| if err != nil { | ||
| require.NoError(t, err) | ||
| } | ||
| os.Setenv("DATA_DIR", dir) | ||
| t.Cleanup(func() { | ||
| os.Unsetenv("DATA_DIR") | ||
| os.RemoveAll(dir) | ||
| }) |
There was a problem hiding this comment.
This is needed both to simplify local testing and also to fix an existing test that was passing purely because of a failure creating the OGG file.
cpoile
approved these changes
Jul 25, 2024
streamer45
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
An interesting case happened during our last developers meeting. If a participant is unmuted when this job starts but mutes right before the matching recording job begins, there could be a situation where the OGG file for the (now muted) track is created but no audio packet is ever written to it. This would cause decoding to fail during the post-call process and the whole job to exit.
PR adds a check to detect if the context is empty (no samples) and avoids sending it. We also make the post-processing side a little more forgiving and just ignore empty audio.
Ticket Link
https://mattermost.atlassian.net/browse/MM-59866