[MM-62662] add ability to compare tables with matching names only #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnivade
approved these changes
Jan 31, 2025
internal/store/compare.go
Outdated
| @@ -45,6 +51,11 @@ func Compare(srcDSN, dstDSN string, opts CompareOptions) ([]string, error) { | |||
| delete(srcTables, k) | |||
| } | |||
| } | |||
| for e := range incl { | |||
| if !strings.Contains(k, strings.ToLower(e)) { | |||
There was a problem hiding this comment.
From the flag documentation, it looked like we should be doing an exact match? In that case, we could probably build up a map and check for this faster, rather than having 2 loops. But, not a blocker.
There was a problem hiding this comment.
I slightly changed the logic, for include scenario it should be an exact match. PTAL @agnivade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For convenience we add a new flag to compare only matching table names.
Ticket Link
https://mattermost.atlassian.net/browse/MM-62662