Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"X" in top right corner of Settings page doesn't have an on hover effect #439

Closed
3 tasks done
jasonblais opened this issue Feb 17, 2017 · 1 comment · Fixed by #614
Closed
3 tasks done

"X" in top right corner of Settings page doesn't have an on hover effect #439

jasonblais opened this issue Feb 17, 2017 · 1 comment · Fixed by #614

Comments

@jasonblais
Copy link
Contributor

I confirm (by marking "x" in the [ ] below):


Summary
"X" in top right corner of Settings page doesn't have an on hover effect

Steps to reproduce

Windows 10; Mattermost Server 3.6; Mattermost Desktop 3.5

  1. Go to File > Settings
  2. Hover over the "X" in top right corner

Expected behavior
On hover effect following Mattermost UX guidelines.

This can be similar to the on hover effect of the "+" icon in desktop server tab bar.

Observed behavior

No on hover effect

@jasonblais jasonblais changed the title "X" in top right corner of Settings page doesn't have an on hover effect [Help Wanted] "X" in top right corner of Settings page doesn't have an on hover effect Feb 26, 2017
@jasonblais jasonblais changed the title [Help Wanted] "X" in top right corner of Settings page doesn't have an on hover effect "X" in top right corner of Settings page doesn't have an on hover effect Mar 22, 2017
@jasonblais jasonblais added this to the v3.9.0/3.10.0 milestone Mar 22, 2017
@jasonblais jasonblais modified the milestones: v3.9.0, v3.8.0 May 12, 2017
wvds pushed a commit to wvds/desktop that referenced this issue Oct 7, 2017
@wvds
Copy link

wvds commented Oct 7, 2017

@jasonblais I've made a small PR where the color of the icon changes to the same color as the "add server" icon. In my opinion that is the nicest solution :)

@jasonblais jasonblais modified the milestones: v3.9.0, v3.8.0 Oct 10, 2017
yuya-oc added a commit that referenced this issue Oct 10, 2017
Implement settings close button hover
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants