Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 7: Clicking on notification should open the message #67

Closed
i23098 opened this issue Mar 11, 2016 · 7 comments
Closed

Windows 7: Clicking on notification should open the message #67

i23098 opened this issue Mar 11, 2016 · 7 comments

Comments

@i23098
Copy link

i23098 commented Mar 11, 2016

Clicking on notification message, should open the application window in the clicked message. At the moment it just opens/focus on the application, but on whatever channel/direct message it was open before.

@yuya-oc
Copy link
Contributor

yuya-oc commented Mar 11, 2016

Please write about your environment. (CONTRIBUTING.md)

Then, does this latest build solve the problem?
https://circleci.com/gh/yuya-oc/electron-mattermost/192#artifacts

@i23098
Copy link
Author

i23098 commented Mar 11, 2016

I'm on Windows 7, 64 bits, using electron-mattermost-v1.0.7-win64.

Using the suggested build, same thing happens, clicking on the notification just switch focus to electron-mattermost app, without changing the conversation to the clicked one.

@yuya-oc
Copy link
Contributor

yuya-oc commented Mar 11, 2016

It's correct behavior since v0.x. On Windows 7 and 8, Notification API is not supported by Electron (to be exact, Windows 8 can support it, but setup will be a little complex).

On Windows 7 and 8, Tray API is used to show balloon and working at src/main.js, it's separated from browser window. So it's hard to implement Notification.onclick event.

@yuya-oc yuya-oc changed the title Clicking on notification should open the message Windows 7: Clicking on notification should open the message Mar 22, 2016
@lunawesley9
Copy link

electron/electron#262

Somebody (second last reply) gave a workaround on windows 7 here.

@seriema
Copy link

seriema commented Jul 8, 2016

@lunawesley9 did you mean this comment? It uses electron-notification-shim. I created it with our HipChat Electron wrapper in mind.

We had started wrapping it all into a electron-notifier for when you just want to add notification toasters for Electron platforms that lack it. We never got around to finishing when the Electron issue got closed as we assumed it'd be as easy on the Mac. If there's interest, we could finish it so feel free to add any issues or submit a PR there.

@jasonblais jasonblais added the Hackfest null label Dec 7, 2016
@jasonblais jasonblais removed the Hackfest null label Jan 9, 2017
@jasonblais jasonblais changed the title Windows 7: Clicking on notification should open the message [Help Wanted] Windows 7: Clicking on notification should open the message Feb 26, 2017
@jasonblais
Copy link
Contributor

@yuya-oc FYI, adding "Help Wanted" tag for issues that are open for community contributions, following the process from platform repo

@jasonblais jasonblais changed the title [Help Wanted] Windows 7: Clicking on notification should open the message Windows 7: Clicking on notification should open the message Mar 22, 2017
@jasonblais jasonblais added this to the Backlog (Unscheduled) milestone Mar 22, 2017
@jasonblais jasonblais modified the milestones: v3.9.0, Unscheduled May 12, 2017
@yuya-oc yuya-oc mentioned this issue May 31, 2017
3 tasks
@jasonblais jasonblais modified the milestones: v3.8.0, v3.9.0 May 31, 2017
@jasonblais
Copy link
Contributor

#543 resolves this issue, thanks @yuya-oc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants