Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS client in the Dock spawns a new copy after restart #705

Closed
3 tasks done
tsilcher opened this issue Jan 31, 2018 · 10 comments
Closed
3 tasks done

macOS client in the Dock spawns a new copy after restart #705

tsilcher opened this issue Jan 31, 2018 · 10 comments

Comments

@tsilcher
Copy link

tsilcher commented Jan 31, 2018

I confirm (by marking "x" in the [ ] below: [x]):


https://mattermost.atlassian.net/browse/MM-14169

Summary

Steps to reproduce

Please include:

  • Operating System: macOS 10.12.6
  • Mattermost Desktop App version: Version 4.0.0 (4.0.0.43)
  • Mattermost Server version: Version: 4.5.0
  • Clear steps to reproduce the issue:
  1. Add the Mattermost client to the Dock
  2. Click on it to launch the app
  3. A new copy of the client is spawned and appears on the right of the Dock
  4. Move this copy to the left inside the Dock to save it as a shortcut
  5. Restart OS
  6. The second copy has now disappeared
  7. (Loop...)

Expected behavior
After adding the Mattermost client to the Dock it should open the same app (bouncing icon like every macOS app, default behavior)

Observed behavior
After adding the Mattermost client to the Dock it open a new copy of the app displaying two Mattermost icons in the Dock.

Please include relevant error messages and/or screenshots:
screen shot 2018-01-31 at 16 47 44
screen shot 2018-01-31 at 16 53 08
screen shot 2018-01-31 at 16 52 43

@jasonblais
Copy link
Contributor

@tsilcher Did you see the issue previously, or is it something new with the new version (v4.0.0)?

@tsilcher
Copy link
Author

tsilcher commented Feb 1, 2018

This was the same behavior on version 3.x for macOS.

@jasonblais
Copy link
Contributor

@tsilcher Thanks!

@yuya-oc If we bundled the Mac app as a .dmg (#588), would it fix the issue? Since then the Mattermost app would always be considered as an "Application" by Mac. I think right now it's not always considered as such, unless the user deliberately moves the file to the Applications folder.

@tsilcher
Copy link
Author

tsilcher commented Feb 1, 2018

Looking a bit deeper I noticed that it is indeed spawning a new instance from a temporary path besides the actual path inside /Applications/. For example:

  1. /Applications/Mattermost.app/Contents/MacOS/Mattermost
  2. /private/var/folders/pk/lcw3xyw97s1416f7thvvlmkht_dlhg/T/AppTranslocation/26A33EB6-428B-4DDA-8D3B-656B2644596F/d/Mattermost.app/Contents/MacOS/Mattermost

@yuya-oc
Copy link
Contributor

yuya-oc commented Feb 5, 2018

@jasonblais
Copy link
Contributor

Does that workaround help you @tsilcher?

@jasonblais jasonblais added the Electron null label Feb 6, 2018
@jasonblais jasonblais added this to the Unscheduled milestone Feb 6, 2018
@tsilcher
Copy link
Author

tsilcher commented Feb 6, 2018

It does not work for me. It seems to be a problem with the Electron framework.

@jasonblais
Copy link
Contributor

Yeah, seems to be a bug with Electron.

I see a note in electron/electron#9293 that Chrome browser for mac is a dmg file that requires user to drag its executive program to ~/Applications... and doesn't reproduce for it. So hopefully the .dmg file would resolve this.

@amyblais
Copy link
Member

Jira ticket for tracking: https://mattermost.atlassian.net/browse/MM-14169.

@esethna
Copy link
Contributor

esethna commented Feb 27, 2019

Should be fixed in v4.2. Please comment if not and we can reopen

@esethna esethna closed this as completed Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants