[MM-37797] Invert check logic #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwilander
approved these changes
Aug 25, 2021
devinbinnie
reviewed
Aug 30, 2021
| @@ -203,13 +203,13 @@ export default class SettingsPage extends React.PureComponent { | |||
| key: 'notifications', | |||
| data: { | |||
| ...this.state.notifications, | |||
| flashWindow: this.flashWindowRef.current.props.checked ? 2 : 0, | |||
There was a problem hiding this comment.
This was breaking for me on my Windows 10 machine for some reason.
devinbinnie
approved these changes
Aug 31, 2021
devinbinnie
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Invert the logic so the check can be actioned
Ticket Link
fix over MM-37797