[MM-47776] Reverse order of input fields in server welcome screen #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboulis
added
2: Dev Review
m1lt0n
reviewed
Oct 24, 2022
There was a problem hiding this comment.
I remember doing this change (the reverse of the changes in this PR) as part of MM-35666 to match mobile. What's the rationale behind reversing the reverse? cc: @devinbinnie
tboulis
changed the title
|
Building app in separate branch. |
|
@tboulis Spacing here looks like a funny:
Anything we can do to fix that? |
|
Updated screenshot in description @devinbinnie |
devinbinnie
approved these changes
Oct 24, 2022
devinbinnie
added
4: Reviews Complete
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
to mattermost-build/desktop
that referenced
this pull request
Oct 24, 2022
…ttermost#2309) * Reverse order of inputs in Server modals (add/edit) * Revert "Reverse order of inputs in Server modals (add/edit)" This reverts commit f3d577d. * Update order of server fields in welcome screens * Update server modal focus test * Add margin between inputs (cherry picked from commit 0f51a62)
mattermod
added
CherryPick/Done
devinbinnie
pushed a commit
that referenced
this pull request
Oct 24, 2022
) (#2314) * Reverse order of inputs in Server modals (add/edit) * Revert "Reverse order of inputs in Server modals (add/edit)" This reverts commit f3d577d. * Update order of server fields in welcome screens * Update server modal focus test * Add margin between inputs (cherry picked from commit 0f51a62) Co-authored-by: Tasos Boulis <tboulis@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reverse order of server input fields in welcome screens
Ticket Link
https://mattermost.atlassian.net/browse/MM-47776
Checklist
Screenshots
Release Note