Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #2310 #2313

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Automated cherry pick of #2310 #2313

merged 1 commit into from
Oct 24, 2022

Conversation

mattermost-build
Copy link
Contributor

Cherry pick of #2310 on release-5.2.

/cc @devinbinnie

NONE

@devinbinnie @mattermost-build
Fix macos-notification-state build issue (mattermost#2310)
6cb320c 
* Fix macos-notification-state build issue

* Fix windows build, a bit of cleanup

(cherry picked from commit 83b6c64)
@mattermod mattermod added this to the v5.2.0 milestone Oct 24, 2022
@mattermod mattermod requested a review from devinbinnie October 24, 2022 14:43
@devinbinnie devinbinnie merged commit 27a64cc into mattermost:release-5.2 Oct 24, 2022
@mattermod
Copy link
Contributor

The file .circleci/config.yml is in the blocklist for external contributors. Hence, these changes are not tested by the CI pipeline active until the build is re-triggered by a core committer or the PR is merged. Please be careful when reviewing it.
/cc @mattermost/core-security @mattermost/core-build-engineers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinbinnie devinbinnie Awaiting requested review from devinbinnie

Assignees

@devinbinnie devinbinnie

Labels
AutomatedCherryPick Changelog/Not Needed Docs/Not Needed release-note-none
Projects
None yet
Milestone
v5.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mattermost-build @mattermod @devinbinnie @mm-cloud-bot