[MM-47801][MM-45980] Added support for security-scoped bookmarks to allow the MAS build to save files wherever needed #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AS build to save files wherever needed
devinbinnie
added
2: Dev Review
tboulis
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
Looks good to me @devinbinnie !!
Thanks for taking care of this <3
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
to mattermost-build/desktop
that referenced
this pull request
Oct 25, 2022
…llow the MAS build to save files wherever needed (mattermost#2315) * First pass * [MM-47801] Added support for security-scoped bookmarks to allow the MAS build to save files wherever needed (cherry picked from commit 635a41f)
mattermod
added
CherryPick/Done
tboulis
pushed a commit
that referenced
this pull request
Oct 25, 2022
…llow the MAS build to save files wherever needed (#2315) (#2316) * First pass * [MM-47801] Added support for security-scoped bookmarks to allow the MAS build to save files wherever needed (cherry picked from commit 635a41f) Co-authored-by: Devin Binnie <52460000+devinbinnie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Because of Apple's App Sandbox, saving files in any location other than the Downloads directory causes a number of issues. In order to resolve these, Apple provides an API called "security-scoped bookmarks" that allows an app to temporarily gain access to a file in the same way that the user would normally pick one using the dialog box and do some work on it.
This PR converts the downloads code to allow for these bookmarks to be created and stored in a persistent manner so that MAS build users can access and save files as normal. This approach conveniently also fixes the issue where users couldn't replace files.
Ticket Link
https://mattermost.atlassian.net/browse/MM-47801
https://mattermost.atlassian.net/browse/MM-45980
Closes #2199