-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump some dev dependencies #307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase and follow my reviews.
"electron-packager": "^7.0.1", | ||
"electron-prebuilt": "1.2.8", | ||
"electron-connect": "~0.6.0", | ||
"electron-packager": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't have to bump electron-packager
. I'm working on updating build commands.
(In addition, gulpfile.js
uses the deprecated parameter, version-string
. So this might break artifacts.)
If you write the detail, for example, the motivation to bump, the part which you checked, etc., it's helpful to review. |
As you wrote, electron 1.4.0 seems to work with the pre-release server and v3.2.0 server. So I think we can bump electron. |
Updated |
welcome back @razzeee :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@razzeee Just curious, post's background blinks when moving the mouse cursor across the posts. Have you experienced? |
@yuya-oc |
Tested again on Window 10 and macOS. On Windows 10, I saw the blinking like the gif (actually, it's very fast blinking). @jasonblais and others, would you check this? On macOS, the app seems to work well. |
Hmm, haven't been able to reproduce the blinking. I tried it on the very same messages you shared above. Does it reproduce consistently across channels and messages? |
@jasonblais Yes, it happens also on channel list, but messages cause that more often. It seems that the vertical position of mouse cursor is randomly wrong in the window, so I see the blinking. Then, I tried the app on some DPI. On 100% and 125%, the problem seems not to happen. On 150%(I'm using), it happens. I think almost of users use 100% or 125%, so I feel we might as well merge this for now. Any thoughts? |
Yeah, I think merging makes sense. Should we add a known issue for the next changelog that using DPI of 150% might cause the vertical position of mouse cursor to be incorrect? It's okay not to fix it, but let's others know about it. |
@jasonblais Sure, that should be written. I add it later. |
Seems to work fine with Mattermost platform pre release and 3.2
You can find builds here: https://circleci.com/gh/Razzeee/desktop/27#artifacts/containers/0