Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #2977 - Fixed the dark-mode style for the download location box in settings #3126

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

theaino
Copy link
Contributor

@theaino theaino commented Aug 17, 2024

Summary

Fixed the dark-mode style for the download location box in settings.

Ticket Link

Fixes #2977

Checklist

  • Added or updated unit tests (required for all new features)
  • Has UI changes
  • [ x read and understood our Contributing Guidelines
  • completed Mattermost Contributor Agreement
  • executed npm run lint:js for proper code formatting
  • Run E2E tests by adding label Run Desktop E2E Tests

Device Information

This PR was tested on: Fedora 40

Screenshots

image

Release Note

Fixed dark-mode style for download location in settings

@mattermost-build
Copy link
Contributor

Hello @theaino,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@devinbinnie devinbinnie added 2: Dev Review Requires review by a core committer Build Apps for PR Builds signed builds for testing labels Aug 19, 2024
@devinbinnie devinbinnie self-requested a review August 19, 2024 13:11
Copy link
Member

@devinbinnie devinbinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theaino! LGTM!

@devinbinnie devinbinnie changed the title Fixed #2977 Fixed #2977 - Fixed the dark-mode style for the download location box in settings Aug 19, 2024
@devinbinnie devinbinnie removed the 2: Dev Review Requires review by a core committer label Aug 19, 2024
@devinbinnie devinbinnie merged commit f8a0903 into mattermost:master Aug 19, 2024
44 of 46 checks passed
@amyblais amyblais added this to the v5.10.0 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Apps for PR Builds signed builds for testing Contributor release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Download location menu label in settings hard to read in dark mode
6 participants