[MM-59823] Migrate BrowserView to WebContentsView
#3177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinbinnie
added
2: Dev Review
devinbinnie
requested review from
pvev,
yasserfaraazkhan,
a team and
enahum
and removed request for
a team
yasserfaraazkhan
added
the
Run Desktop E2E Tests
|
Here are the test results below: Test Summary for Linux on commit a0c98b6The following known failed tests have been fixed on Linux: Test Summary for macOS on commit a0c98b6New failed tests found on macOS:
The following known failed tests have been fixed on macOS: Test Summary for Windows on commit a0c98b6All stable tests passed on Windows. |
github-actions
bot
removed
the
Run Desktop E2E Tests
yasserfaraazkhan
approved these changes
Oct 24, 2024
pvev
approved these changes
Oct 24, 2024
|
/update-branch |
|
@enahum Gentle ping for review :) let me know if I need to re-assign |
Sorry was not in my radar, I can give it a review in about 12h or so |
enahum
approved these changes
Oct 30, 2024
devinbinnie
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A while back, Electron implemented
BrowserViewas an experimental way of nesting sandboxed Chromium views inside of a main windows, replacingwebview. However, for the longest time that functionality remained experimental and not fully supported.This PR migrates us over to the new
WebContentsView, introduced in Electron 30 which should be more stable and supported. It should also simplify resizing logic.Ticket Link
https://mattermost.atlassian.net/browse/MM-59823