[MM-60080] Fixed the MAS migration from the DMG build, fixed a potential crash case #3186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinbinnie
requested review from
enzowritescode,
a team,
fmartingr and
marianunez
and removed request for
a team
fmartingr
approved these changes
Nov 4, 2024
enzowritescode
approved these changes
Nov 4, 2024
devinbinnie
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
At some point, the MAS migration broke due to what I assume is a change in behaviour of
fs.cpSync. To copy directories now, you need to includerecursive: trueas an option. This is likely something that changed in macOS, as Node doesn't seem to make any mention of this.While investigating and fixing the issue, I ran into a case where the app can crash due to certain singletons that might try to register a duplicate handler.
This PR fixes both of the above issues.
Ticket Link
https://mattermost.atlassian.net/browse/MM-60080