[MM-61821] Automatically allow permission checks for supported permission types through for GPO configured servers #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion types through for GPO configured servers
devinbinnie
added
2: Dev Review
devinbinnie
requested review from
a team and
davidkrauser
and removed request for
a team
devinbinnie
requested review from
enzowritescode,
Rajat-Dabade and
larkox
and removed request for
Rajat-Dabade
larkox
approved these changes
Nov 27, 2024
| @@ -152,6 +153,12 @@ export class PermissionsManager extends JsonFileManager<PermissionsByOrigin> { | |||
| return false; | |||
| } | |||
|
|
|||
| // For GPO servers, we always allow permissions since they are trusted | |||
| const serverHref = serverURL.href; | |||
| if (Config.registryData?.servers?.some((s) => parseURL(s.url)?.href === serverHref)) { | |||
There was a problem hiding this comment.
Just sanity check question. At Config.registryData?.servers? we only have GPO servers, right?
There was a problem hiding this comment.
Correct, they are servers that come from the Windows registry. I was considering doing all predefined servers (including ones specified by the build), but I thought that might expose people to be tricked into downloading an app with a pre-configured server that has access to everything.
|
@enzowritescode Gentle ping for review :) |
enzowritescode
approved these changes
Dec 3, 2024
devinbinnie
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a small QoL improvement for enterprise users who have their Desktop App configured for them by their system administrator. Normally the application will ask for permission to send notifications, access the camera/microphone, and other system related permissions on a per-server basis. However, if the server is configured using Group Policy on Windows, we can make an assumption that the server is trusted since it is configured at the registry level.
This PR just removes the permission check for those servers.
Ticket Link
https://mattermost.atlassian.net/browse/MM-61821