Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SBOM version so the file output is sbom-desktop-vX.Y.Z.json #3257

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

enzowritescode
Copy link
Contributor

Summary

Change SBOM file from sbom.json to sbom-desktop-vX.Y.Z.json

Ticket Link

https://mattermost.atlassian.net/browse/SEC-7235

Release Note

NONE

secrets: inherit
with:
is_monorepo: false
repo_name: desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line may be removed after this is merged: mattermost/actions-workflows#52

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I will need to remove that and then update the commit hash. I have it staged locally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enzowritescode enzowritescode marked this pull request as draft December 16, 2024 16:59
@enzowritescode enzowritescode marked this pull request as ready for review December 16, 2024 17:31
@enzowritescode enzowritescode merged commit e869a74 into master Dec 17, 2024
13 checks passed
@enzowritescode enzowritescode deleted the improved-sbom-filename branch December 17, 2024 15:18
@enzowritescode
Copy link
Contributor Author

/cherry-pick release-5.9

@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit that referenced this pull request Dec 17, 2024
* Bump SBOM version so the file output is sbom-desktop-vX.Y.Z.json

(cherry picked from commit e869a74)
@enzowritescode
Copy link
Contributor Author

/cherry-pick release-5.10

@mattermost-build mattermost-build added the CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone label Dec 17, 2024
@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit that referenced this pull request Dec 17, 2024
* Bump SBOM version so the file output is sbom-desktop-vX.Y.Z.json

(cherry picked from commit e869a74)
enzowritescode added a commit that referenced this pull request Dec 17, 2024
…) (#3260)

* Bump SBOM version so the file output is sbom-desktop-vX.Y.Z.json

(cherry picked from commit e869a74)

Co-authored-by: enzowritescode <1328683+enzowritescode@users.noreply.github.com>
enzowritescode added a commit that referenced this pull request Dec 17, 2024
…) (#3259)

* Bump SBOM version so the file output is sbom-desktop-vX.Y.Z.json

(cherry picked from commit e869a74)

Co-authored-by: enzowritescode <1328683+enzowritescode@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants