Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue where server select menu was not working in settings page #444

Merged
merged 1 commit into from
Feb 22, 2017

Conversation

yuya-oc
Copy link
Contributor

@yuya-oc yuya-oc commented Feb 21, 2017

Before submitting, please confirm you've

Please provide the following information:

Summary
Fix an issue where server select menu was not working in settings page.

In v3.5.0, the behavior of #443 is expected because the config is not saved yet in the settings page.
Now the config is auto-saved, so I added an event listener for menu items.

Issue link
#443

Test Cases

  1. Open the settings page.
  2. Select a server from the tray icon menu or "Window" menu items.
  3. The selected server' tab should be shown in the main window.

Additional Notes
https://circleci.com/gh/yuya-oc/desktop/167#artifacts

@jasonblais
Copy link
Contributor

+1, works for me. Great work @yuya-oc!

@jasonblais
Copy link
Contributor

@yuya-oc might be okay if you helped test this on Mac, so we can get it in to 3.6

@yuya-oc
Copy link
Contributor Author

yuya-oc commented Feb 22, 2017

I see. Tested on macOS 10.12.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants