Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update settings text for "Flash taskbar icon when..." #452

Merged
merged 3 commits into from
Feb 22, 2017

Conversation

jasonblais
Copy link
Contributor

Before submitting, please confirm you've

Please provide the following information:

Summary
Update settings text for "Flash taskbar icon when..." to "Flash app window and taskbar icon when a new message is received", as the latter is the actual behaviour of the setting.

Issue link
#447

Test Cases

  1. Go to File > Settings
  2. Confirm the settings text reads Flash app window and taskbar icon when a new message is received
  3. Confirm the help text reads If enabled, app window and taskbar icon flashes for a few seconds when a new message is received.

@jasonblais jasonblais added this to the v3.6.0 milestone Feb 22, 2017
@jasonblais
Copy link
Contributor Author

@yuya-oc I updated the help text based on your reply to #447.

Maybe have your help verify, and we can update for 3.6?

Artifact here: https://circleci.com/gh/mattermost/desktop/896#artifacts

@jasonblais jasonblais requested a review from yuya-oc February 22, 2017 15:28
@jasonblais
Copy link
Contributor Author

Screenshot here from Windows 10:

image

Copy link
Contributor

@yuya-oc yuya-oc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@caspChristian
Copy link

Is there any way to have Mattermost keep flashing until it gets focus? - as it is now I, and many in my team, keeps missing important messages because they where busy with something else for few minutes

@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Linux Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants