Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md for 3.7 #521

Merged
merged 5 commits into from
Apr 30, 2017
Merged

Update CHANGELOG.md for 3.7 #521

merged 5 commits into from
Apr 30, 2017

Conversation

jasonblais
Copy link
Contributor

Before submitting, please confirm you've

Please provide the following information:

Summary
Update CHANGELOG.md for 3.7

@jasonblais jasonblais requested a review from yuya-oc April 29, 2017 06:48
CHANGELOG.md Outdated
#### All Platforms
- Added an inline spell checker for English, French, German, Spanish, and Dutch. [#225](https://github.com/mattermost/desktop/issues/225)
- Removed an obsolete "Display secure content only" option, following an [upgrade of the Electron app to Chrome v56](https://github.com/electron/electron/commit/2e0780308c7ef2258422efd34c968091d7cd5b65). [#469](https://github.com/mattermost/desktop/pull/469)
- Refactored main app window code for ... [#470](https://github.com/mattermost/desktop/pull/470)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if there's anything we can mention here that the PR improved (e.g. performance, rendering, .... ?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this time, the refactoring affects its code structure only.

Copy link
Contributor

@yuya-oc yuya-oc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appropriate! Please see minor comments.

CHANGELOG.md Outdated
- The application now respects 125% of display scaling.
- [Windows 7/8] Added support for sound when a desktop notification is received. [#467](https://github.com/mattermost/desktop/issues/467)
- Removed obsolete support for Japanese fonts.
- Removed blurriness on the app window at 125% display resolution.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


#### Windows
- Removed Japanese fonts support it's no longer necessary.
- Added support for sound notifications on Windows 7 and 8.
- The application now respects 125% of display scaling.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is also necessary. The size was also changed not only blurriness.
#459 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's right. I'll change it back to that since it would cover the blurriness too

CHANGELOG.md Outdated
#### All Platforms
- Added an inline spell checker for English, French, German, Spanish, and Dutch. [#225](https://github.com/mattermost/desktop/issues/225)
- Removed an obsolete "Display secure content only" option, following an [upgrade of the Electron app to Chrome v56](https://github.com/electron/electron/commit/2e0780308c7ef2258422efd34c968091d7cd5b65). [#469](https://github.com/mattermost/desktop/pull/469)
- Refactored main app window code for ... [#470](https://github.com/mattermost/desktop/pull/470)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this time, the refactoring affects its code structure only.

@jasonblais
Copy link
Contributor Author

Thanks! I've updated the PR

CHANGELOG.md Outdated
- Added an inline spell checker for English, French, German, Spanish, and Dutch. [#225](https://github.com/mattermost/desktop/issues/225)
- Removed an obsolete "Display secure content only" option, following an [upgrade of the Electron app to Chrome v56](https://github.com/electron/electron/commit/2e0780308c7ef2258422efd34c968091d7cd5b65). [#469](https://github.com/mattermost/desktop/pull/469)
- Reset app window position when restoring it off-screen from a minimized state. [#471](https://github.com/mattermost/desktop/issues/471)
- Improved page loading and app view rendering when waking computer from sleep.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I had forgot to write about this. #495 is still pending though, what part is the factor for this log?

Copy link
Contributor Author

@jasonblais jasonblais Apr 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote that entry based on #515 -- it's not a fix for #495 but I understood it fixed an issue when loading the page?

EDIT: Sorry, I wonder if this a more appropriate description:

Improved page loading and app view rendering.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, appropriate.

@jasonblais jasonblais added this to the v3.7.0 milestone Apr 29, 2017
Copy link
Contributor

@yuya-oc yuya-oc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@yuya-oc yuya-oc merged commit bed558d into release-3.7 Apr 30, 2017
@yuya-oc yuya-oc deleted the jasonblais-patch-1 branch April 30, 2017 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants